AntelopeIO / reference-contracts

Other
10 stars 14 forks source link

Change new params in logbuyram and logsellram to binary extensions #85

Closed nsjames closed 5 months ago

nsjames commented 5 months ago

Previously these params were simply added to the end of the action param list, and tests did not catch the problem because they were only using the new actions and never the old ones.

This wraps those new parameters in binary extensions so that it won't throw the assertion failure with message: datastream attempted to read past the end error.

nsjames commented 5 months ago

It seems that this is more of an issue with signers and how and when they refetch ABIs than an issue that requires binary extensions (against the original document for them that specifies that they are required for action parameter additions).

We can close this issue out with no-action as this shouldn't be an issue.