search

AntelopeIO / spring

C++ implementation of the Antelope protocol with Savanna consensus
Other
5 stars 2 forks source link

Remove `kv_database_config` from `snapshot_global_property_object` #102

Closed linh2931 closed 4 months ago

linh2931 commented 4 months ago

https://github.com/AntelopeIO/spring/issues/77 calls for removing kv_database_config from the global_property_object and from the snapshot. It was only removed from global_property_object but not from snapshot_global_property_object by PR https://github.com/AntelopeIO/spring/pull/99. Removal from snapshot_global_property_object should be done separately as additional work is required to make sure old snapshots can be loaded.

heifner commented 4 months ago

Looks like it was removed: https://github.com/AntelopeIO/spring/pull/99/files#diff-60e9aa15db2886d950de829a0a602fe29fe4e69f28621e45be60e46a51c096a5L75

linh2931 commented 4 months ago

Looks like it was removed: https://github.com/AntelopeIO/spring/pull/99/files#diff-60e9aa15db2886d950de829a0a602fe29fe4e69f28621e45be60e46a51c096a5L75

Thanks. It was removed from global_property_object but not from snapshot_global_property_object. I changed the title.