search

AntelopeIO / spring

C++ implementation of the Antelope protocol with Savanna consensus
Other
10 stars 5 forks source link

[1.0.4 -> main] Merge fix flaky startup catchup test #1042

Closed linh2931 closed 4 days ago

linh2931 commented 4 days ago

Forward https://github.com/AntelopeIO/spring/pull/1033 with updated pattern of unlinkable blocks on the main branch.

The test on main counts the total number of unlinkable_block occurrences in all logging files and checks if it is greater than 500 or not. This is flaky because when sync fetch span is greater than 500 (default is 1000), temporary unlinkable blocks can be greater than 500.

This PR changes to check the number of consecutive unlinkable blocks in each logging file is less than sync fetch span (the worst case).

Resolves https://github.com/AntelopeIO/spring/issues/1015

ericpassmore commented 3 days ago

Note:start category: Tests component: Internal summary: Fix nodeos_startup_catchup tests. Note:end