AntelopeIO / spring

C++ implementation of the Antelope protocol with Savanna consensus
Other
9 stars 5 forks source link

Test failure: finality_unit_test #106

Closed heifner closed 6 months ago

heifner commented 6 months ago

https://github.com/AntelopeIO/spring/actions/runs/8929191201/job/24526863069

 684/2043 Test   #88: finality_unit_test_eos-vm-jit ......................***Failed   20.24 sec
Random number generator seeded to 1714677816
Running 19 test cases...
10 assert_exception: Assert Exception
retrys: Never saw this nodes vote processed before timeout
    {}
    unit_test  tester.cpp:504 _wait_for_vote_if_needed
rethrow
    {}
    unit_test  finality_tests.cpp:252 test_method

unknown location(0): fatal error: in "finality_tests/long_delayed_votes": std::runtime_error: Caught Unexpected Exception
/__w/spring/spring/unittests/finality_tests.cpp(245): last checkpoint
greg7mdp commented 6 months ago

There were many issues with these tests. I'll have a PR up today with significant updates of these tests in finality_tests.cpp.

I think we may want to close this issue, and see if it happens again before spending time on this.

heifner commented 6 months ago

Assuming this was fixed by: https://github.com/AntelopeIO/spring/pull/108 unless it happens again.