search

AntelopeIO / spring

C++ implementation of the Antelope protocol with Savanna consensus
Other
9 stars 5 forks source link

Test failure: lib_advance_test #224

Closed heifner closed 5 months ago

heifner commented 5 months ago

https://github.com/AntelopeIO/spring/actions/runs/9353204320/job/25743769240

  File "/__w/spring/spring/build/tests/lib_advance_test.py", line 131, in <module>
    assert prodD.waitForLibToAdvance()

It is stuck thinking the peer it needs blocks from is syncing from it. I believe we need to send a handshake when verify_catchup is in lib_catchup. Currently it just silently returns and no other progress is made.

https://github.com/AntelopeIO/spring/blob/5cb602003e7e40054aae05f6f90bdb524859111f/plugins/net_plugin/net_plugin.cpp#L2396-L2396

arhag commented 5 months ago

Does not need to be a blocker for Spring 1.0 stable, but should be an easy 1-line fix.