search

AntelopeIO / spring

C++ implementation of the Antelope protocol with Savanna consensus
Other
5 stars 2 forks source link

Test failure: lib_advance_if_test #302

Closed heifner closed 2 months ago

heifner commented 3 months ago

https://github.com/AntelopeIO/spring/actions/runs/9547360011/job/26312762056

Traceback (most recent call last):
  File "/__w/spring/spring/build/tests/lib_advance_test.py", line 102, in <module>
    assert prodA.waitForNextBlock(timeout=6), "Production node A should continue to advance, even after bridge node is killed"
AssertionError: Production node A should continue to advance, even after bridge node is killed
heifner commented 3 months ago

Producer D (node03) did not send out its produced block to bridge node because peer_syncing_from_us was true. It did come out of peer syncing with us but only right after the 6 block timeout.

A longer timeout would have allowed it to figure this out. However, the node03 should not have peer_syncing_from_us == true as the bridge node had not been syncing with it expect at startup.

linh2931 commented 2 months ago

https://github.com/AntelopeIO/spring/actions/runs/9654126075/job/26628097702#step:4:1046

File "/__w/spring/spring/build/tests/lib_advance_test.py", line 102, in <module>
    assert prodA.waitForNextBlock(timeout=6), "Production node A should continue to advance, even after bridge node is killed"
heifner commented 2 months ago

https://github.com/AntelopeIO/spring/actions/runs/9654126075/job/26628097702#step:4:1046

File "/__w/spring/spring/build/tests/lib_advance_test.py", line 102, in <module>
    assert prodA.waitForNextBlock(timeout=6), "Production node A should continue to advance, even after bridge node is killed"

Did not have the fix merged to main yet.