search

AntelopeIO / spring

C++ implementation of the Antelope protocol with Savanna consensus
Other
5 stars 2 forks source link

Fork choice rule: determine whether we should use `last_qc_block_num` or `last_qc_block_timestamp`. #330

Closed greg7mdp closed 2 months ago

greg7mdp commented 2 months ago

Currently, we use last_qc_block_num as the third criteria in our fork choice rule:

https://github.com/AntelopeIO/spring/blob/a9e4dcfbca2464a255fc453341034df48d193554/libraries/chain/fork_database.cpp#L91-L99

Determine whether we should use last_qc_block_timestamp instead.

arhag commented 2 months ago

We should also use last_final_block_timestamp.