search

AntelopeIO / spring

C++ implementation of the Antelope protocol with Savanna consensus
Other
5 stars 2 forks source link

Test Failure: nodeos_read_terminate_at_block_if_lr_test #38

Closed linh2931 closed 4 months ago

linh2931 commented 5 months ago

https://github.com/AntelopeIO/spring/actions/runs/8707646627/job/23883711651#step:4:711

heifner commented 5 months ago

Failure of terminate-at-block when running in irreversible mode. This failure is caused by blocks being able to be applied during log_irreversible. The terminate_at_block checks chain_head in push_block. This allows bsp to be added to the forkdb and processed during log_irreversible. Need to check bsp in push_block and not allow it to be processed if > than terminate_at_block.