search

AntelopeIO / spring

C++ implementation of the Antelope protocol with Savanna consensus
Other
5 stars 2 forks source link

Move get_info from chain_api_plugin to http_plugin #506

Closed heifner closed 1 month ago

heifner commented 1 month ago

As of https://github.com/AntelopeIO/leap/pull/1137 v1/chain/get_info has been part of the node http category. The node category, it is NOT user configurable because it is available for all listened http addresses.

Often users enable eosio::chain_api_plugin only so that v1/chain/get_info is available.

Move get_info to http_plugin so that is always available if any API plugin or even just http_plugin is enabled. This would enable nodes to be run without having to enable the eosio::chain_api_plugin and still have get_info available.

spoonincode commented 1 month ago

It is strange that get_info is on the node category, but what's the reasoning for further special-casing it vs just adding it to chain_ro?

heifner commented 1 month ago

It is strange that get_info is on the node category, but what's the reasoning for further special-casing it vs just adding it to chain_ro?

The point of it being in node category was so it would always be available on all endpoints.

heifner commented 1 month ago

Replaced by #515