AntelopeIO / spring

C++ implementation of the Antelope protocol with Savanna consensus
Other
9 stars 5 forks source link

Test proposer policy does not become active when finality has stalled #553

Closed arhag closed 2 months ago

arhag commented 2 months ago

Add an additional libtester test (though using the Savanna cluster testing utility) to test new behavior of https://github.com/AntelopeIO/spring/issues/454.

Create a test where we partition the network (two nodes on one side and two nodes on the other side). Propose a new proposer policy in this scenario and notice that it does not become active. Then reconnect the network and finality should start advancing again and the proposer policy should automatically be promoted to become active.

arhag commented 2 months ago

https://github.com/AntelopeIO/spring/pull/582 also resolves this issue.

greg7mdp commented 2 months ago

Actually I misread the issue, #582 does not resolve it, will implement the test.