AntelopeIO / spring

C++ implementation of the Antelope protocol with Savanna consensus
Other
5 stars 1 forks source link

Reject p2p connections from nodes without support for active protocol features #611

Open heifner opened 3 weeks ago

heifner commented 3 weeks ago

Any Leap node connected to network when it activates Savanna will be hard-forked out. That Leap node will repeatedly request blocks from its peers because it will not be able to process received blocks.

After Savanna is activated (one proper Savanna block received), net_plugin could reject connections from net versions pre proto_savanna. Then the node would not waste time sending blocks to a node that can't process them.

matthewdarwin commented 3 weeks ago

jungle-dm12 - leap 5.0 jungle-trxrly173 - spring 1.0-rc2

from leap 5.0 side:

image

from spring 1.0 side:

image

bhazzard commented 1 week ago

This should be generalized for future hard fork releases to the case where new protocol features are activated, rejecting p2p connections from nodes without those protocol features.