AntennaHouse / pdf5-ml

Antenna House PDF5-ML DITA-OT Plug-in
23 stars 9 forks source link

table/@rowheader: Query for rowheader will never return true #158

Closed AndeeZee closed 3 years ago

AndeeZee commented 3 years ago

Hello! The following part in tableelements.xsl of the PDF5-ML Plugin will never fire, because @rowheader is not an attribute of entry, but of table and/or colspec. As far as I understand the following code, @rowheader is checked for /entry and not for the /table and/or /colspec:

<!-- rowheader -->
<xsl:if test="(string($prmEntry/@rowheader) eq 'firstcol') and ($colName= 'col1')">
  <xsl:sequence select="ahf:getAttributeSet('atsHeaderRow')"/>
</xsl:if>

Would you be so kind to have a look into this?

Kind regards, Andy

ToshihikoMakita commented 3 years ago

You are right. @rowheader attribute should be taken from tgroup or colspec elements.

AndeeZee commented 3 years ago

Just a minor correction for the last comment: @rowheader attribute should be taken from table ~tgroup~ or colspec elements

ToshihikoMakita commented 3 years ago

Thank you for your correction.

3.12.4 Complex-table attribute group

The @rowheader attribute is available on the following table elements: <table> and <colspec>.

ToshihikoMakita commented 3 years ago

Added the test result.

20200730-rowheader.zip

ToshihikoMakita commented 3 years ago

Should I close this issue?

AndeeZee commented 3 years ago

Hello! Sorry for the late reply. I wasn't able to update my environment but checking the samples you provided, the table in question looks good now. So I'll close this issue. Kind regards, Andy