search

AntennaHouse / pdf5-ml

Antenna House PDF5-ML DITA-OT Plug-in
23 stars 9 forks source link

"Table continued" text generated by default #166

Closed steinbacher01 closed 3 years ago

steinbacher01 commented 3 years ago

Is it possible to have "Table continued" text generated by default without adding outputclass="output-continued-in-table-title"?

There are many large tables in our content and our writer's would prefer this to be the default.

Thanks,

Leroy Steinbacher

ToshihikoMakita commented 3 years ago

I will add parameter that forces to output "continued word" to table.

ToshihikoMakita commented 3 years ago

Fork (or download) the latest master branch and set following two properties before importing com.antennahouse.pdf5.ml/build.xml.

<property name="output.table.title.continued" value="yes"/>
<property name="output.table.footer.continued" value="yes"/>
steinbacher01 commented 3 years ago

Thank you for the quick response. I downloaded and tested the latest. It is working as expected, however I noticed a minor regression error for tables with frame="none".

tableFrameNone

I think it is forcing an empty thead (or something similar) in tables that don't have a thead.

Any suggestions?

Thanks,

Leroy

ToshihikoMakita commented 3 years ago

Good point! You have found the unimplemented bug of this table layout feature. I will begin analyzing the stylesheet code. Please give me a time little!

ToshihikoMakita commented 3 years ago

Added the test result: mTableContinuedTest3.pdf.

mTableContinuedTest3.pdf cFrameTest.zip

ToshihikoMakita commented 3 years ago

The master branch has been updated. Could you confirm the fixes with your test data?

steinbacher01 commented 3 years ago

Thanks for the update. It is now working as expected.

steinbacher01 commented 3 years ago

I just discovered another regression error introduced by this parameter.

If I add this to build.xml

<property name="output.table.title.continued" value="yes"/>

For tables with no title, the table desc element gets duplicated in the output.

tableDesc

tableDesc1

It works as expected for tables with title.

Any suggestions?

Thanks,

Leroy Steinbacher

ToshihikoMakita commented 3 years ago

I could reproduce the problem like this:

desc-duplicate_New

Give me a time to analyze the cause.

ToshihikoMakita commented 3 years ago

I've fixed the problem. When following property is specified as yes but there is no table/title, this property should be ignored because there is no opportunity to add "Continued" word to table tittle.

<property name="output.table.title.continued" value="yes"/>

[The test result]

mTableContinuedTest4.pdf

The fix now exists in the develop branch.

ToshihikoMakita commented 3 years ago

The fix now exists in the develop branch.

Merged develop into master.

steinbacher01 commented 3 years ago

Thanks for the fix! It is now working as expected.