search

AntennaPod / AntennaPod

A podcast manager for Android
https://www.antennapod.org
GNU General Public License v3.0
6.28k stars 1.39k forks source link

Video Player: Lock controls during playback #1195

Closed RKDTOO closed 5 years ago

RKDTOO commented 9 years ago 
1. Lock controls during video play

2. 10 sec jumps 3. Closed Captioning\Subtitles [not supported by android]

mfietz commented 9 years ago

-> https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md "How to submit a feature request"

RKDTOO commented 9 years ago

mfietz, I have checked the existing issues and couldn't find any listings with like requests.

Thanks.

mfietz commented 9 years ago

My trouble is rather with

To be honest, writing down some "notes"... no real explanation or ideas how this is used... quite looks like you don't really care. This is not really motivating me spent several hours implementing your requests

  1. Lock controls during video play

How am I supposed to pause, fast forward etc.? Not sure what you are actually requesting Do you want some lock/unlock controls button?!

  1. 10 sec jumps

Already implemented, try long pressing the controls.

  1. Closed Captioning\Subtitles

Not sure this is very useful. Are there even video podcasts that have subtitles?

TomHennen commented 9 years ago

Also important, each feature request should be a different issue.

On Thu, Sep 10, 2015, 12:32 PM Martin Fietz notifications@github.com wrote:

My trouble is rather with

  • Give a brief explanation about the problem that currently exists and why your requested feature solves this problem.
  • Try do be as specific as possible. Please not only explain what the feature does, but also how. When your request is about changing or extending the UI, describe what the UI would look like and how the user would interact with it.

To be honest, writing down some "notes"... no real explanation or ideas how this is used... quite looks like you don't really care. This is not really motivating me spent several hours implementing your requests

  1. Lock controls during video play

How am I supposed to pause, fast forward etc.? Not sure what you are actually requesting Do you want some lock/unlock controls button?!

  1. 10 sec jumps

Already implemented, try long pressing the controls.

  1. Closed Captioning\Subtitles

Not sure this is very useful. Are there even video podcasts that have subtitles?

— Reply to this email directly or view it on GitHub https://github.com/AntennaPod/AntennaPod/issues/1195#issuecomment-139302630 .

RKDTOO commented 9 years ago

My apologies. I actually was attempting to be concise. The first 2 features are very common.

  1. Indeed I meant the Lock\Unlock button; so that during video play one can Lock the controls from accidentally, changing the position for example, or clicking the back and\or main button. This is not necessary during Audio play, because locking the device accomplishes this without interrupting the audio.
  2. Oh I see! It does exist when I play Audio podcast (I so far only indulged in video); but there aren't such options during video play; would be nice.
  3. Yes, there are; for example "Democracy Now!", or C-Span videos. As I understand they have a Closed Captioning stream (ex: DFXP/TTML) embedded inside the video file. The Subtitles, as I understand, are different in that they are not embedded, but defined in an external file (ex.: srt), which the user would need to have on their device to point to. It is useful not only to ones hard of hearing but also to non-native English speakers, makes it easier for them to understand if they can read along; some CC and Subs can also be in the users' native language.

Perhaps I should have defined each of these in a separate Issue post afterall. Let me know if I should.

Thanks!

mfietz commented 9 years ago

Still looking for a feed that has videos with subtitles. Looked into http://www.democracynow.org/podcast-video.xml, videos there had no subtitle (VLC, MPlayer) For c-span, I could only find MP3 feeds, so nothing you could actually subscribe to in APod...

RKDTOO commented 9 years ago

Correct, I just looked, DN! do not have embedded Closed Captioning in the MP4, they seem to use the Subtitle File approach. By the way VLC doesn't seem to support DFXP format; I use youtube-dl to extract those kinds of CC. But nonetheless - if I have a sub file for a given episode or show, It'd be nice to have an option to use it. :)

mfietz commented 9 years ago

Having a "add subtitles" button where a dialog pops up where the user can select a compatible subtitle file from the devices file system after she manually transmitted it there (or maybe Dropbox)... seems far too user-unfriendly, don't think this will happen.

For me the only two possible solutions are:

  1. Subtitles are embedded in the file. That is why I'd like to see some actual podcast doing this. Android doesn't seem to support this out-of-the-box, but maybe exporting the subtitles from a track/stream isn't that hard
  2. The podcast's feed points us directly to the subtitle file (WebVTT format). Haven't seen one of those yet.
RKDTOO commented 9 years ago

Well, this would be indeed a sort of "super-user" feature. VLC does that. However I accept your reasoning - even though c-span's MP4s have embedded CC stream they don't provide video podcast feeds it seems, and feeds in general don't provide an external sub file, you're right; although if this sort of feature became a standard among podcast players, maybe they would start ;).

P.S. I will create separate Issues for the first 2 shortly.

keunes commented 9 years ago

If you're creating new issues for the other requests, maybe you could rename this issue to cover your CC request for archiving purposes :)

mfietz commented 9 years ago

VLC does that.

I just have to answer ^^ Well, VLC is an actual video player, while I regard APod more focused on audio. Besides that, VLC uses its own library and not Android's native one. That means it comes with all kinds of cool video and audio codecs (a lot more than Android natively supports), but alone adds about 15 MB to the app (APod currently is at a little over 2 MB...) In my opinion, if people really want more video features that we can easily provide, they should use a dedicated video player. We should probably provide some kind of "Open with..." functionality for that, will look into it if I find some time (backlog is pretty long)

frederickjh commented 7 years ago

In my opinion, if people really want more video features that we can easily provide, they should use a dedicated video player. We should probably provide some kind of "Open with..." functionality for that, will look into it if I find some time (backlog is pretty long)

@mfietz This is exactly what we were asking for in #100

ByteHamster commented 5 years ago

so that during video play one can Lock the controls from accidentally, changing the position for example

All playback buttons are hidden if you do not touch the screen for a few seconds. So you need to press two times to change anything. Adding a lock button would also need two presses, so it will not really make it more safe. Additionally, I do not want to clutter the interface with even more buttons.

The other two items in the first post got resolved during discussion.