Option to reduce/turn off border radius of podcast cover art

AntennaPod / AntennaPod

A podcast manager for Android

https://www.antennapod.org

GNU General Public License v3.0

6.37k stars 1.4k forks source link

Option to reduce/turn off border radius of podcast cover art #6827

Closed ch3thanhs closed 9 months ago

ch3thanhs commented 10 months ago

Checklist

[X] I have used the search function for OPEN issues to see if someone else has already submitted the same feature request.
[X] I have also used the search function for CLOSED issues to see if the feature was already implemented and is just waiting to be released, or if the feature was rejected.
[X] I will describe the problem with as much detail as possible.
[X] This request contains only one single feature, not a list of multiple (related) features.

App version

3.2.0

Where did you get the app from

Google Play

Problem you may be having, or feature you want

The podcast cover art in certain podcasts have a border, but the uniform border radius applied to all podcast covers within the app gives them a somewhat awkward appearance near the edges.

Example -

Screenshots / Drawings / Technical details

No response

keunes commented 9 months ago

Hello, As far as I'm aware this shouldn't be happening. Two questions:

Which screen did you take the screenshot from? (Home, Subscriptions, …)
Which podcasts are they? Please share the RSS URL – you can find this if you open the subscription, tap on the ℹ️ icon in the header and then long-press the URL.

ch3thanhs commented 9 months ago

I took the screenshot from the 'Subscriptions' screen, but this is how the podcast covers appear on every screen in the app - i.e., with rounded corners.
The podcasts are Search Engine and S-Town

tonytamsf commented 9 months ago

Hello, As far as I'm aware this shouldn't be happening. Two questions:

Which screen did you take the screenshot from? (Home, Subscriptions, …)

Which podcasts are they? Please share the RSS URL – you can find this if you open the subscription, tap on the ℹ️ icon in the header and then long-press the URL.

@keunes FYI: I think we do round the corners using this type of code. It's 16 pixels for the CoverFragment

                        new RoundedCorners((int) (16 * getResources().getDisplayMetrics().density)));

https://github.com/AntennaPod/AntennaPod/blob/b066c6e23c335f79b624e90f15aaeb32f8a1cf81/app/src/main/java/de/danoeh/antennapod/fragment/CoverFragment.java#L273

keunes commented 9 months ago

I'm sorry, I misread the original post. Indeed we add a border radius (rounded corners). But I thought the image was too small or something, causing the white border background.

But as written in the Original Post, as I saw now in the feed, these borders are added by the podcast creators. Honestly, that's just bad design for this purpose, as the creators have no control over appearance (as the image is used in a vast variety of apps).

Either way, as it's working as expected on our side and a setting doesn't enable a new use-case, we won't implement that, sorry.