Rounded corners for contributor avatars

[flofriday]

Checklist

• [X] I have used the search function for OPEN issues to see if someone else has already submitted the same feature request.
• [X] I have also used the search function for CLOSED issues to see if the feature was already implemented and is just waiting to be released, or if the feature was rejected.
• [X] I will describe the problem with as much detail as possible.
• [X] This request contains only one single feature, not a list of multiple (related) features.

App version

3.3.2f (develop branch)

Where did you get the app from

Other

Problem you may be having, or feature you want

All over the app we are using (somewhat) rounded corners on images. However, the avatars of contributors have sharp corners.

Suggested solution

Make the avatars display with round corners.

Screenshots / Drawings / Technical details

Screenshots (before/after)

Technical Details Currently I am using the follwing code to determine the roundness of the corners. I think it looks the best, but if you have suggestions for a different size please let me know.

 new RoundedCorners((int) (6 * context.getResources().getDisplayMetrics().density))

Also I already implemented the change and will open an PR as soon as this change is approved.

[ByteHamster]

6dp are a quite uncommon number in material design. It only uses multiples of 4. Would making them completely round make sense? The icons are circles on GitHub web as well.

[flofriday]

I see, yeah we can go with full round circles, which really does look more like GitHub.

Just in case the screenshot below also includes 4 and 8:

[keunes]

I would personally rather keep consistency within the app (e.g. episode covers)/Android than with GitHub (which most of our users aren't familiar with). That said, email/chat apps often use circles for contacts so I guess that'd be OK as well.

[keunes]

Looking at the screen it'd actually be nice to be able to tap on the names, and open the profiles (on GitHub).

[flofriday]

Sure, I think all the usernames in developer.csv are already the one from Github so that should be doable work.

Edit: yeah they must be cause we are loading the profile image from Github.