search

AntennaPod / AntennaPod

A podcast manager for Android
https://www.antennapod.org
GNU General Public License v3.0
5.97k stars 1.35k forks source link

Add support for parsing Nero M4A chapters #7159

Closed IsAvaible closed 4 weeks ago

IsAvaible commented 1 month ago

Description

This pull request adds a simple M4A parser to detect and read Nero type chapters. I do not intend to implement parsing QuickTime type chapters, as it requires a more elaborate process.

Most M4A editors (such as FFMPEG) embed both types of chapters in the media file, so nonetheless a high percentage of M4A files with chapters should be supported after this pull request is merged.

As the previous test file only embedded QT chapters, I have added a new test file with Nero type chapters (nero-chapters.m4a).

partially fixes #4311

IsAvaible commented 4 weeks ago

@ByteHamster I have made some changes to the pull request, trying to keep the commits atomic. I think you should get a good overview of the changes by stepping through each commit and reading the commit message.

ByteHamster commented 4 weeks ago

Thanks! Will be released in 3.5.x

40ZqTYY4ag3tAO4hdlxR1 commented 4 weeks ago

@IsAvaible Vielen Dank 🙂

IsAvaible commented 3 weeks ago

Thanks! Will be released in 3.5.x

Great, glad to contribute!