Closed flofriday closed 3 weeks ago
Also another question, why is there a refresh button in the dialog? Does it refresh the chapter parsing? Or does it reload the episode? Or just the chapter information?
Thanks!
why is there a refresh button in the dialog?
It's shown when the podcast uses Podcasting2.0 chapters, which are not encoded in the media file but in a json file on some web server. AntennaPod caches that json file quite aggressively but you can press the button to reload.
Description
If only some chapters have images the other chapters don't display anything but reserve space for the image.
Now those chapters display the image of the episode. If no chapters have images no images will be displayed (just like before).
Checklist
./gradlew checkstyle spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug
Alternative Implementation: We could also just remove the reserved space if the chapter has no image. This means that the items wouldn't be aligned but chapters without images would have more space to display information. This is not my preferred solution but I am happy to hear your feedback.
Screenshots: left: current, middle: preferred solution (this PR) right: alternative implementation