Antergos / Cnchi

A modern, flexible online system installer for Antergos Linux
GNU General Public License v3.0
291 stars 101 forks source link

Generated lightdm Xsession misidentifies KDE #1145

Closed ethanwu10 closed 5 years ago

ethanwu10 commented 5 years ago

Describe the bug (This is a bug in the files generated by Cnchi, not Cnchi itself per se)

Cnchi's /etc/lightdm/Xsession file does not properly test for KDE, and thus starts qt5ct for KDE sessions leading to issues like antergos/antergos-packages#455. KDE now uses startkde and not plasma, so the script misidentifies it as not a QT-based DE.

The fix is simply to add startkde to the list of commands the script is checking for

To Reproduce Steps to reproduce the behavior: On a system with the faulty Xsession file

  1. Install qt5ct (now required by antergos-common-meta as of this commit)
  2. Launch a KDE session using lightdm
  3. KDE themes are not applied and are unchangeable

Expected behavior KDE theming should work

Screenshots N/A

Log Files N/A

Patch (since I have no idea which branch to submit a PR to :upside_down_face:)

--- a/scripts/postinstall/Xsession
+++ b/scripts/postinstall/Xsession
@@ -65,7 +65,7 @@
     sleep 2
 fi

-if ! [[ "${@}" =~ plasma|lxqt ]]; then
+if ! [[ "${@}" =~ plasma|startkde|lxqt ]]; then
     # Fix ugly styles for Qt applications when running under GTK-based desktops and Qt 5.7+
     export QT_QPA_PLATFORMTHEME='qt5ct'
     unset QT_STYLE_OVERRIDE
ethanwu10 commented 5 years ago

Fixed in c6f5874