Antergos / Cnchi

A modern, flexible online system installer for Antergos Linux
GNU General Public License v3.0
291 stars 101 forks source link

Gummiboot + Encryption broken again #351

Closed ghost closed 9 years ago

ghost commented 9 years ago

I will take a look as soon as I have time Just wanted to let you know I don't have an exact crashlog, I just remember the log said something like "cryptAntergos" found but int required.

ghost commented 9 years ago

now tested a bit more

didn't work on my laptop, desktop and a vm (on which I'm testing atm)

log:

[2015-05-28 21:02:32] [bootloader] DEBUG: Cnchi will install the Gummiboot loader
[2015-05-28 21:02:32] [misc] WARNING: invalid literal for int() with base 10: 'ptAntergos'
[2015-05-28 21:02:32] [fs_module] WARNING: Command '['blkid', 'cryptAntergos']' returned non-zero exit status 2
[2015-05-28 21:02:32] [process] WARNING: While installing boot loader Cnchi encountered this error: 'UUID'

Off-topic: I really have a problem with your code being so complicated by trying to be modular or somthing like that.. I can't deal with it. Would you have a problem with me writing functional, short code? Just a short "yes, everybody can do as they like" or "no, we have guidelines on that". Please no explanation or excuse.

karasu commented 9 years ago

Thanks for the warnings, we will check this asap

About the code, yes, you can write whatever you want, then we will adapt it if necessary.

Cheers!

ghost commented 9 years ago

as far as I've looked into this the problem could be here

lots0logs commented 9 years ago

:triumph: haha it works. you see what I did @karasu?

I am reopening this ticket, the above was just a test for something not directly related to this ticket.

karasu commented 9 years ago

Yep, https://github.com/lots0logs/cnchi-dev/commit/1107412afedc056064122de3483d78f0fe0eb792 fixes it!