search

Antergos / Cnchi

A modern, flexible online system installer for Antergos Linux
GNU General Public License v3.0
291 stars 101 forks source link

Advanced Mode: Require boot partition for UEFI systems if bootloader installation is enabled #371

Closed lots0logs closed 8 years ago

lots0logs commented 9 years ago

If the user has chosen to install bootloader on a UEFI system, /boot/efi mount point is required. Currently the user is able to continue without specifying the mount point which results in an unbootable system. This was working properly last I checked so it seems to be a regression.

karasu commented 9 years ago

Not again! :laughing:

Just in case you don't remember, code is in method check_mount_points() in advanced.py

karasu commented 9 years ago

Oh, as it is now, with grub2 it should enforce it, but with gummiboot doesn't. Do not know why.

lots0logs commented 9 years ago

It was a colleague of mine from work that brought this to my attention. He said it happened with Grub2. I will check it out myself ASAP.

jscholfield commented 9 years ago

For clarity sake, the mount point determines what partition the kernel will reside on. /boot puts the kernel on the $ESP and /boot/efi puts it on the / partition. This does make a difference depending on the boot loader used. When no boot loader is used, /boot must be the mount point because the UEFI can only directly load kernels from the $ESP. It should also be considered that if multiple distros get installed with /boot as the mount point, there can be issues where multiple kernels are at the root of the $ESP.

The Arch wiki gives this pretty good treatment for reference. It boils down to needing to handle both single OS and dual/multiple boot well, handle no boot loader/manager or boot loaders or boot managers. I'd add that defaults should be determined from what is learned from the user choices during installation and it may be appropriate to ive some users choices, such as users doing their own partitioning for example.

jscholfield commented 9 years ago

I recommend these be the boot loader options.

karasu commented 9 years ago

@lots0logs : Have you got any time to check this out?

karasu commented 9 years ago

@lots0logs I can't reproduce it here. There's a bug in the forward button, though.

antergos uefi

lots0logs commented 9 years ago

@karasu Hmm..his partition layout included two drives (one ssd and one hdd). His existing EFI partition was on the SSD while he was installing Antergos to the HDD. I will try to find some time to look at it soon!

karasu commented 9 years ago

@lots0logs : Maybe he forgot to set the mount point? Dunno...

lots0logs commented 9 years ago

@karasu I think you might have misunderstood the issue. Cnchi should have shown that the mountpoint was required in the mount checklist but it did not. Furthermore it let him continue without the mount point set which it shouldn't have.

karasu commented 9 years ago

Cnchi should have shown that the mountpoint was required in the mount checklist but it did not.

Oh, then forget my last comment :grin:

OK. He was using UEFI, I suppose. As you can see in the image, cnchi in fact does ask for /boot/efi if it's run in an UEFI system (not in a BIOS one, of course).

There must be some combination ¿? that makes Cnchi stop asking for a /boot/efi partition.

karasu commented 9 years ago

Oh, and I think we can release even if this issue is not yet solved... it's been too long since latest release (again). If you agree I will make 0.9.249 the next 0.10 (and then you can create a new iso with it :grimacing: )

lots0logs commented 8 years ago

I'm pretty sure this has been resolved, we can reopen if I am wrong.