Antergos / Cnchi

A modern, flexible online system installer for Antergos Linux
GNU General Public License v3.0
291 stars 101 forks source link

ZFS issues #557

Open NanoSector opened 8 years ago

NanoSector commented 8 years ago

Problem:

Installing Antergos with ZFS using the Automatic method has some serious issues. For one, the swap partition doesn't get added correctly to fstab (don't use UUIDs, but zvol's) Second, /home partition does not get added at all and therefore causes the system not to boot.

Steps To Reproduce:

  1. Install antergos with ZFS option and Automatic method

    Log Files

Supplied by zark_:

IRC log from #antergos:

<zark_> hi
<zark_> The antergos cnchi installer doesn't setup the SWAP device correctly.
<zark_> I don't know what /dev/zd0 is but it seems that it's the swap device
<zark_> this is in /etc/fstab  /dev/zd0: UUID="57623913-6914-4dbf-9ef6-83ee20796d2d" TYPE="swap"
<zark_> blkid returns /dev/zd0: UUID="57623913-6914-4dbf-9ef6-83ee20796d2d" TYPE="swap"
<zark_> however systemd doesn't find the swap device and times out after 1min 30sec
* usaf_ has quit (Ping timeout: 276 seconds)
<zark_> And the zfs-mount.service is NOT enabled, which is the cause for /home not being mounted. This should be in the post-setup script. systemctl enabled zfs-mount.service
* NanoSector pokes karasu0
<zark_> Ok I found the error
<zark_>  /etc/fstab is WRONG about the Swap device. 
<zark_> it should NOT be a UUID, but it should be the zvol name. Here's what it must contain: /dev/zvol/antergos_<id>/swap  none  swap  defaults  0  0
<zark_> <id> is of course just a placeholder
* NanoSector repeatedly pokes karasu0 with a stick
* karasu0 has quit (Quit: Connection closed for inactivity)
<NanoSector> think i killed him
<NanoSector> https://github.com/Antergos/Cnchi/blob/f563f030943b499aaffec3d228e28adaac4392cf/cnchi/installation/install.py#L500
<FatalException> [http://is.gd/BZF3EZ] Cnchi/install.py at f563f030943b499aaffec3d228e28adaac4392cf · Antergos/Cnchi · GitHub
<NanoSector> https://github.com/Antergos/Cnchi/blob/f563f030943b499aaffec3d228e28adaac4392cf/cnchi/installation/install.py#L542
<FatalException> [http://is.gd/hNnIg8] Cnchi/install.py at f563f030943b499aaffec3d228e28adaac4392cf · Antergos/Cnchi · GitHub
<NanoSector> that line needs a conditional if using zfs
<zark_> it jumps to the else clause, the defaults,discard should be found there instead of just defaults 
<zark_> indeed a zfs clause would help
* palasso has quit (Remote host closed the connection)
<NanoSector> doesi t do stuff correctly for other partitions?
<zark_> hmm almost.. /home is not mounted if it's a seperate partition
<zark_> but the remedy is easy and should be done by cnchi. just running  systemctl enable zfs-mount.service fixes it
<zark_> or manually running zfs mount -a
NanoSector commented 8 years ago

Apparently it is documented here: https://github.com/zfsonlinux/pkg-zfs/wiki/HOWTO-use-a-zvol-as-a-swap-device

karasu commented 8 years ago

Thanks @Yoshi2889 , this is going to be very helpful. I'll try to fix this asap.

karasu commented 8 years ago

Version 0.14.66 should fix it. If somebody is so kind to test it... if not I will do it asap.

Thanks!

thinktapper commented 8 years ago

im ready to test! ..but the current dev pull is still at 14.62 i guess ill see if there's any action on the build server.. otherwise would it be practical for me to compile it within a live iso?

thinktapper commented 8 years ago

i have some fresh logs && error messages captured all related to varying zfs automatic installation casualties; however, there seems to already be a handful of separate zfs related issues opened at the moment so would it be more or less helpful for me to just append these to an already established issue, such as this?

karasu commented 8 years ago

Hi,

Nope, latest commit is https://github.com/Antergos/Cnchi/commit/474bced9bed2fba3856618e2df412ee3609a993e

You can clone the repository from the live iso: git clone https://github.com/Antergos/Cnchi cnchi

so would it be more or less helpful for me to just append these to an already established issue, such as this?

Please, if is related with an existing issue, append to it. If not, open a new one.

Thanks!

thinktapper commented 8 years ago

right on.. since i was last on here i actually did manage to pull the latest source using the cnchi-dev PKGBUILD with minor adjustments. Still same errors from at that time..which surely predated e85ceb8b509e568afa5c1d1507bd5bed52d7404f so I'll try again once more, and return with some loggage

skjeggape commented 7 years ago

Any update on this?