Antergos / Cnchi

A modern, flexible online system installer for Antergos Linux
GNU General Public License v3.0
291 stars 101 forks source link

Cnchi partitioning bugs #716

Open ghost opened 7 years ago

ghost commented 7 years ago

Problem:

My first Antergos installation, I installed pure Arch just a couple of days ago so this might be just me.

Everything goes well until the partitioning part, I create a new EFI partition and fill it (screenshot 1), apply, but the result shows fat instead of fat32(screenshot 2).

Screenshot1: http://i.imgur.com/36mjqzC.png Screenshot2: http://i.imgur.com/lRsZPrC.png

Next, I try to add the root partition (screenshot 3), this time the type is applied properly but the label is lost (screenshot 4) it does get fixed however once I re-edit the entry again.

Screenshot 3: http://i.imgur.com/vGQkZ49.png Screenshot 4: http://i.imgur.com/sJZ6iiy.png

Next, the boot partition. I fill it (screenshot 5), this time the type is changed from ext4 to fat (kind of like the EFI) and the label is lost again (screenshot 6). When I try to change the entry, the type shows as ext4 not fat like it was showing so it might be a graphical bug. The label however, is not back (screenshot 7), the editing fixes it too though. Swap worked perfectly.

Screenshot 5: http://i.imgur.com/Dutx62y.png Screenshot 6: http://i.imgur.com/JRudD76.png Screenshot 7: http://i.imgur.com/XZdZbh7.png

The final result (screenshot 8) shows no mountpoint bugs (they never needed editing), no label bugs (root and boot were edited on the process), and two type bugs (efi and boot). What's weird again is coming back to the type bugs and editing them shows the type as swap not fat (screenshot 9), clicking apply changes the type and mountpoint into swap and changing in it back to EFI and mountpoint /boot/efi gives the same result I got when initially setting efi but editing it again shows fat32 and not just fat like on all the partitions list. And editing the boot partition that also has fat type into ext4 changes the efi type into ext4 too (on the edit part not on the all partitions list part).

Screenshot 8: http://i.imgur.com/yfKUwt3.png Screenshot 9: http://i.imgur.com/doXiCNG.png

I'm pretty sure editing this more will show new variations but I just want to go ahead and try installing, maybe it's all graphical.

Log Files

cnchi.log: https://paste2.org/K0yw9C7e

pacman-boot.log https://paste2.org/MC12XHc1

postinstall.log: will add after install.

karasu commented 7 years ago

Everything goes well until the partitioning part, I create a new EFI partition and fill it (screenshot 1), apply, but the result shows fat instead of fat32(screenshot 2).

For Cnchi fat and fat32 are the same, as it never uses fat16. Anyway, you're right that it should show fat32 all the time. I've fixed it. https://github.com/Antergos/Cnchi/commit/61687efdf915e3e2a3dc48340ed324e20af66f30

I try to add the root partition (screenshot 3), this time the type is applied properly but the label is lost (screenshot 4) it does get fixed however once I re-edit the entry again.

Graphical glitch bug. Fixed (I need to test it more, though). https://github.com/Antergos/Cnchi/commit/c6536b7778f360e4022c284e9fd79c836bf15a1c

karasu commented 7 years ago

Next, the boot partition. I fill it (screenshot 5), this time the type is changed from ext4 to fat (kind of like the EFI) and the label is lost again (screenshot 6). When I try to change the entry, the type shows as ext4 not fat like it was showing so it might be a graphical bug. The label however, is not back (screenshot 7), the editing fixes it too though. Swap worked perfectly.

Cnchi enforces to use fat32 in /boot when using UEFI. That's because some people don't create a /boot/efi partition, so EFI goes to /boot/efi folder in the /boot partition. In these cases if /boot is not fat32 the system will not be able to read /boot/efi when booting. I'll think about a better solution.

I'd guess that the label problem is the same as before.

karasu commented 7 years ago

And this one https://github.com/Antergos/Cnchi/commit/d5700e3a01f085eed6c2f4ac6a5fcf754392ced5 should warn the user about when /boot needs to be fat32 (and when it changes /boot/efi to enforce it being fat32)