Antergos / antergos-packages

PKGBUILD's for antergos packages
114 stars 50 forks source link

antergos-gnome-meta > pamac tray is invisible on default GNOME installation. #274

Closed killajoe closed 5 years ago

killajoe commented 6 years ago

pamac tray do not work without topicons-plus and the package (topicons) from Antergos-Repo do not work:

https://forum.antergos.com/compose?p=/topic/8763/antergos-gnome-17-12-missing-libs-right-after-fresh-install/27

What happens?

  1. pamac tray is invisible on default GNOME installation. 1a. topicons-plus and chrome-gnome-shell is not installed by default GNOME installation!
  2. installing topicons from Antergos-Repo and enable it 2a. still no pamac tray icon visible.
  3. Uninstalling topicons package and use topicons-plus directly from gnome-shell-extensions side works without a problem!
karasu commented 6 years ago

There's something wrong with that package. I did confirm it a few days ago (so it should be available), but it hasn't been moved by the ABS (it's still in the antergos staging repo).

staging repo version 1:21-1 normal repo version 1:20-1

@lots0logs please, can you fix this?

(also, it's showing the "updating antergos-staging repo database...." message all the time).

killajoe commented 6 years ago

21 is still not come into normal repo... updkg is from 17.9.2017:

[ANTBS] | [updpkg] gnome-shell-extension-topicons ('20', '21') master 1 parent 8565a0e commit 9f4e717566aba159c6a10f500ded9b6a28713a59 @antbs antbs committed on 17 Sep 2017

But also maintainer stops developing Topicons-Plus:

This repository has been archived by the owner. It is now read-only.

https://github.com/phocean/TopIcons-plus/issues/91

I can see on local building that md5sums changed...

md5sums=('fb49eafbe269ad303ab347f2ef5e2dee')

killajoe commented 6 years ago

As we mainly need this for pamac-tray-icon, may there is a possibillity to get it working without legacy-tray-icon?

killajoe commented 6 years ago

Manjaro uses this one: https://github.com/manjaro/packages-community/tree/master/gnome/gnome-shell-extension-manjaro-update

karasu commented 6 years ago

It's this one "rebranded": https://github.com/RaphaelRochet/arch-update

Added (will show Arch icons and not Antergos ones) here: https://github.com/Antergos/antergos-packages/commit/49a9e05f962005edc838dd8daf8e607a9527444c

Still on staging only. Needs testing.

killajoe commented 6 years ago

I see this too after cloning from manjaro... I will try out, may I already see how to change icons😑

killajoe commented 6 years ago

still an issue ;)

luisfpg commented 6 years ago

Starting with GNOME 3.28, legacy tray support was completely dropped. Also, topicons will not work again. Ubuntu uses the appindicator extension: https://extensions.gnome.org/extension/615/appindicator-support/ Pamac already ships the pamac-tray-appindicator extension for KDE support. Maybe a better option would be to enable that one for GNOME as well; I did it by editing /etc/xdg/autostart/pamac-tray.desktop and /etc/xdg/autostart/pamac-tray-appindicator.desktop and just replaced KDE; by KDE;GNOME; in both OnlyShowIn and NotShowIn. Of course, I think Antergos should ship the indicators extension by default instead of TopIconsPlus, as it is non-funcional nowadays anyway...

killajoe commented 6 years ago

nice find! i will check this!

killajoe commented 6 years ago

This is an very easy and working solution! thanks @luisfpg !!

pamac-tray-1

luisfpg commented 6 years ago

For a general replacement of the indicator extension over TopIconsPlus, there's a catch on applications that use electron, such as Skype, because of this bug: https://github.com/electron/electron/issues/10427 Electron uses a dummy way to check whether indicators are supported: testing the XDG_CURRENT_DESKTOP environment variable. If running on Unity, Pantheon, Ubuntu's GNOME or PopOS's GNOME, it enables indicators. So, to make such applications work, one has to fool them by setting the proper environment variable. So, for example, I've made a copy of my $HOME/.config/autostart/skypeforlinux.desktop to some other name (because Skype will override it) and replaced the Exec line by this: Exec=env XDG_CURRENT_DESKTOP=Unity /usr/bin/skypeforlinux. This way the icon is correctly shown. I hope the electron bug can be resolved quickly, so no workarounds are needed for users to see the (ever growing list of) electron apps icons in the panel. Other applications, such as Dropbox or Chromium show their icons as indicators out of the box.

killajoe commented 6 years ago

i would like to get this installed by default on Antergos Gnome setup :)

luisfpg commented 6 years ago

There is still another thing to consider when implementing this: KDE Plasma's implementation of StatusNotifierItem seems to be broader than the one in Unity / GNOME extension. For example, in Plasma, a specific event is triggered on click, whereas in Unity / GNOME the menu is shown as well. If I'm not mistaken, in Plasma, when left-clicking the icon, Pamac opens with the Updates tab open, so they can be applied. In GNOME extension, however, clicking brings up the menu, which has the menu items "Package manager" and "Quit" (maybe not exactly the same text because I use it in Portuguese). And clicking on "Package manager" opens Pamac in the standard install mode, not on updates. So, I suggest to also add another item in the SNI's context menu to open Pamac in update mode already. Otherwise, people would get confused on how to install the actual updates.

killajoe commented 6 years ago

yes i can see thios in gnome-shell left and right click on the icon open the menu

killajoe commented 6 years ago

So, I suggest to also add another item in the SNI's context menu to open Pamac in update mode already.

can you make this more clear to me ;)

luisfpg commented 6 years ago

So, I suggest to also add another item in the SNI's context menu to open Pamac in update mode already.

can you make this more clear to me ;)

There are 2 menu items when clicking the pamac indicator:

Selecting "Package manager" opens pamac not in the Update model, but as if one would install another application.

My proposal is to have the following menu structure when there are updates available:

So the user knows that right after clicking the first menu item, the available updates will be shown. BTW, in KDE, that is exactly what happens when clicking the icon (left clicking is not supported in Unity / GNOME extension - it just shows the menu as if one would have right clicked).

killajoe commented 6 years ago

Like This?

[Desktop Entry]
Name=Update Notifier Appindicator
Icon=update-notifier
Exec=env XDG_CURRENT_DESKTOP=Unity pamac-tray-appindicator
Terminal=false
Type=Application
StartupNotify=true
OnlyShowIn=GNOME;
luisfpg commented 6 years ago

For pamac you don't need env XDG_CURRENT_DESKTOP=Unity

Would be something like:

$HOME/.config/autostart/pamac-tray-appindicator.desktop:

[Desktop Entry]
Name=Update Notifier Appindicator
Icon=update-notifier
Exec=pamac-tray-appindicator
Terminal=false
Type=Application
StartupNotify=true
OnlyShowIn=KDE;GNOME;

$HOME/.config/autostart/pamac-tray.desktop:

[Desktop Entry]
Name=Update Notifier
Icon=update-notifier
Exec=sh -c "GDK_BACKEND=x11 pamac-tray"
Terminal=false
Type=Application
StartupNotify=false
NotShowIn=KDE;GNOME;
killajoe commented 6 years ago

ah yes i got it... i do not get where the menu is edited.. i was thinking that the XDG_CURRENT_DESKTOP will give the gtk dialogues instead of the qt ones :(

menu-pamac-appi

killajoe commented 6 years ago

https://github.com/manjaro/pamac/blob/master/src/tray-appindicator.vala

killajoe commented 5 years ago

No package manager showing up to show available updates for default GNOME Desktop.... We should solve this.

killajoe commented 5 years ago

gnome-shell-extension-topicons-plus-git from AUR is working nicely on a tryout at the moment.... so may merging this to build a package and adding it to GNOME desktop?

killajoe commented 5 years ago

someone is developing topicons again now> https://gitlab.com/pop-planet/TopIcons-Redux

killajoe commented 5 years ago

but i see this today in tweaks -- extensions: bildschirmfoto vom 2019-01-31 10-34-49 enable it and got this: pamac-app-indicator

killajoe commented 5 years ago

Not needed anymore as there is an extension for pamac tray icon on its own now... This could be enabled by default on GNOME install ...