search

Antergos / web-greeter

A modern, visually appealing greeter for LightDM.
http://antergos.github.io/web-greeter
GNU General Public License v3.0
233 stars 57 forks source link

Web-greeter seems to crash if LightDM doesn't define a default language #165

Open TLATER opened 6 years ago

TLATER commented 6 years ago

I'm not sure how I managed to construct a system that doesn't have this set, but it can happen according to the pygobject API reference, so this once it hopefully isn't only me.

Should this occur, we hit this code with lang set to None - I get a constantly-restarting lightdm as a result, having to rely on journalctl -xe to even see the exception.

TLATER commented 6 years ago

Hmm, upon closer inspection it appears that this happens if no system locale is set.

The "workaround" is setting the system locale (localectl is your friend), but it would probably still be nice if overlooking this didn't cause lightdm to crash in a mysterious way.

lots0logs commented 6 years ago

I'm not sure I'd consider this a bug though if it is a bug, it's a LightDM bug (not web-greeter).

TLATER commented 6 years ago

@lots0logs I don't think I agree with that assessment - it's a perfectly valid state for the system not to have a default language set - LightDM decided to signify that state by returning None. It would be a LightDM bug if LightDM crashed in that case.

The issue is that web-greeter does not handle this state correctly - it should probably, instead of crashing, either use some hardcoded default language or prompt the user to choose one.