search

Antergos / web-greeter

A modern, visually appealing greeter for LightDM.
http://antergos.github.io/web-greeter
GNU General Public License v3.0
233 stars 57 forks source link

Possible mock.js mistake #88

Closed FallingSnow closed 7 years ago

FallingSnow commented 7 years ago

Is this line supposed to be if ( !('lightdm' in window) ) instead of the current if ( ! 'lightdm' in window )?

lots0logs commented 7 years ago

Yep, you are right!

homer-simpson-doh

FallingSnow commented 7 years ago

@lots0logs Could you give me a little guidance on how to use mock.js. I'm trying to use it via require('mock.js'). I get ReferenceError: LightDMGreeter is not defined.

lots0logs commented 7 years ago

Actually the mock.js doesn't work right now. I kind of broke it a bit while shuffling stuff around. Though I don't think we need it anymore because its now possible to interact directly with the greeter and LightDM from within your user session. All you have to do is add a line to the .desktop file for your session. I use cinnamon so the file for me is /usr/share/xsessions/cinnamon.desktop. The line to add is: X-LightDM-Allow-Greeter=true. You have to restart lightdm after editing the desktop file. Then you should be able to simply launch the greeter from a terminal lightdm-webkit2-greeter

FallingSnow commented 7 years ago

I see. Thanks for letting me know. I tried using lightdm-webkit2-greeter but I get much better performance and less artifacts with dm-tool add-nested-seat --screen 1920x1080.

lots0logs commented 7 years ago

Hmm..I wasn't aware of that dm-tool option. Simply launching the greeter itself works fine for me. No performance problems once so ever :eyes: Anyway, I think that I changed my mind on not keeping mock.js script. Its useful for creating greeter theme demos that can be accessed in normal web browsers so I'll try to fix it soon.

FallingSnow commented 7 years ago

Idk, I switched back to the modesetting driver because I get much better chromium performance (among other things). Perhaps that is the cause of the poor performance. I also have a 4k display which creates artifacts when using lightdm-webkit2-greeter compared to dm-tool add-nested-seat --screen 1920x1080. Anyway, thanks as always @lots0logs.

lots0logs commented 7 years ago

@FallingSnow Just fyi, the performance issue with webkitgtk and the intel driver has been fixed. I'm not sure about Chromium though.

FallingSnow commented 7 years ago

I've known about the performance fix, it only fixed performance being abysmal. But I had performance issues before that regression. I believe it has to do with my screen being 4k.

I'm doing a rewrite of the material theme in react so we'll see if the performance was something associated with the angular version or the issue is something deeper (I assume it's something deeper).

lots0logs commented 7 years ago

I'm doing a rewrite of the material theme in react

Nice! I've been wanting to rewrite the default theme in react but havent found the time yet. Let me know how yours turns out :smiley:

Edit: Btw, have you been testing with the master branch of the greeter? I'm curious to know if everything is okay with 3rd-party themes. I've only tested it with the default themes. I'm hoping to get a release out soon...

FallingSnow commented 7 years ago

No, I've been using lightdm-webkit2-greeter-2.1.6-1. Is there a quick and easy way to install the master branch on arch?

lots0logs commented 7 years ago

Sure, there's a package in our repo called lightdm-webkit2-greeter-next

FallingSnow commented 7 years ago

Got it installed. I'll use it from here on out and let you know if I run into any issues.