search

Antergos / web-greeter

A modern, visually appealing greeter for LightDM.
http://antergos.github.io/web-greeter
GNU General Public License v3.0
233 stars 57 forks source link

lightdm-webkit2-greeter-next does not show users #91

Closed FallingSnow closed 7 years ago

FallingSnow commented 7 years ago

Just restarted my computer today, got to a login screen which seemed to load a mock login with Clark Kent. I'm using the material theme. It would seem that the new greeter did not load lightdm as a global variable causing the theme to believe it was in "demo mode".

Downgrading the 2.1.6-1 fixes this.

lots0logs commented 7 years ago

Could you post the logs? Thanks.

lots0logs commented 7 years ago

@FallingSnow I think this has to do with your trying to use the lightdm variables before they are ready. Could you try ensuring you dont start until window load event?

FallingSnow commented 7 years ago

Ok, seems to be fixed. I have however noticed now that a warning about the theme not working correctly with the possibility to change themes always pops up. I haven't actually tried to sign in with the material theme but it seems to functioning normally.

lots0logs commented 7 years ago

@FallingSnow The notice is part of a new safe guard I implemented to try and ensure that users are never stuck at the login screen unable to log in due to theme errors. If the notice is getting triggered its because there are errors being output to the console in the theme's javascript execution environment.

FallingSnow commented 7 years ago

I see, then it appears to be working as expected.

Another issue I ran into (I'll have to double check), when using the currently released material theme you are unable to sign in. I believe this is due to the change from lightdm.start_authentication(user) to lightdm.authenticate(user).

lots0logs commented 7 years ago

I believe this is due to the change from lightdm.start_authentication(user) to lightdm.authenticate(user).

Indeed. I think I am going to add a shim for that old method for just one release cycle since the material theme is pretty popular.

FallingSnow commented 7 years ago

Yeah I would say just deprecate it, don't remove it.

lots0logs commented 7 years ago

Its actually been deprecated since version 2.0.0. I wanted to remove it for 2.2 thinking its been enough time but I guess one more cycle can't hurt.

FallingSnow commented 7 years ago

Haha, then I guess it being in material is my fault, sorry about that.

On another note, does the fallback prompt trigger if there is a warning, because I was just prompted and the console only has a warning.

lots0logs commented 7 years ago

Well, ideally no it wouldnt. But there is no way to tell with any certainty the level of the message. Even though the webkit2 console api says it tells you the level I discovered that its doesnt work right. So what we're doing currently is checking for the phrase "Error" or "Exception" in any console message.