search

Antgr36 / MMM-SpeedTest

Bandwidth test from speedtest.net servers for MagicMirror
MIT License
0 stars 1 forks source link

Error Installing #10

Open Dresch360 opened 1 month ago

Dresch360 commented 1 month ago

Thank you for the module! After trying to install, I get the error message "No versions available for magicmirror-rebuild"

Specs: MM Version: 2.27.0 Pi 5 - 32bit version node v20.8.0 npm v10.1.0

Any help is greatly appreciated!

mathew-fleisch commented 1 month ago

It seems this package depends on: https://github.com/bugsounet/MagicMirror-rebuild

cc @bugsounet

Perhaps there is something wrong with this automation because I don't see a package with this name in npm: https://www.npmjs.com/search?q=MagicMirror-rebuild

I tried installing the MagicMirror-rebuild tool manually but kept getting the following error:

$ MagicMirror-rebuild

An unhandled error occurred inside MagicMirror-rebuild
Unable to find electron's version number, either install it or specify an explicit version

Error: Unable to find electron's version number, either install it or specify an explicit version
    at /REDACTED/MagicMirror-rebuild/build/cli.js:87:19

I also tried to comment this section out to get it running: https://github.com/Antgr36/MMM-SpeedTest/blob/master/package.json#L21 https://github.com/Antgr36/MMM-SpeedTest/blob/master/installer/postinstall.sh#L31-L35

this results in another error, this time in the MagicMirror display

Main Library not loaded, npm run rebuild needed!

Running npm run rebuild just errors out as well.

bugsounet commented 1 month ago

Hi, sorry, it's not my repo @Antgr36 ?

mathew-fleisch commented 1 month ago

@bugsounet this is the repo that is failing. it is yours is it not? https://github.com/bugsounet/MagicMirror-rebuild

bugsounet commented 1 month ago

don't confuse github and npm. it's different This repo is a test repo for my personal use and not a production repo

NPM version is not owned by me

Note for no confuse: Your repository "bugsounet/MagicMirror-rebuild" was successfully deleted.

mathew-fleisch commented 1 month ago

Weird. I don't see any other package with this name. Sorry to bother you https://github.com/Antgr36/MMM-SpeedTest/blob/master/package.json#L21

bugsounet commented 1 month ago

So it's means that it's deleted from npm

mathew-fleisch commented 1 month ago

@bugsounet though it is @Antgr36's repo, it looks like it was you that introduced this dependency: https://github.com/Antgr36/MMM-SpeedTest/commit/10a00f5e7cab7be932fa2456e8cb2d49f786b7d7#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R14-R17

And since the repo you deleted was a fork of this electron-rebuild repo: https://github.com/Antgr36/MMM-SpeedTest/commit/ba44bfb7a444b83b3fcec2ed016609e538116ecd#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R16

I've raised a PR to revert the now deprecated MagicMirror-rebuild command to the original electron-rebuild that it was forked rom https://github.com/Antgr36/MMM-SpeedTest/pull/11

I got it working locally 🤷