search

Anthirian / script.service.janitor

Janitor is an addon for Kodi that cleans up any watched videos from your hard drive(s) based on various criteria
GNU General Public License v3.0
26 stars 14 forks source link

Small corrections #89

Closed kugan49 closed 3 years ago

kugan49 commented 3 years ago

Hi,

I love your work and can't wait for it to be stable on kodi 19, so i have some tweaks for you that make it work for me :

Code formatting to comply with PEP (formatted with Black).

I tried to use standard codification for better compréhension, it's just about layout

Encoding management in the log recording (in case of file or folder with accented letters)

My directories and filenames contains accented letters, it throwed an error when you append it to logfile

Correction of the window invocation in case of error

When there was an error the dialog().Ok was not using the correct parameters

If you want I could help you on other points.

Anthirian commented 3 years ago

Thanks for pointing out to the issues you were having with the current version. I had tested the log file parts with accented letters but not characters from a different alphabet. I took a different route while fixing it though, since your solution produced lines such as b'\x02\x03\x05\x03.mkv' which was counterproductive. Regarding the PEP8 parts I prefer to keep the layout as is for the most parts while still refactoring. I probably need to make a lot more changes, which is why the PEP8 formatting is best reserved for the end result. I have thus created some new commits based on the summary you describe above, which unfortunately makes your pull request obsolete, which is why I'm closing it. I really appreciate the help though! Feel free to submit a new pull request for any other issue you encounter with this branch later on.