Update my-slider.ts - Githubissues

tmooze commented 2 years ago

Solves issue #29. Tested with MacOS Safari Version 15.5 and Safari on iOS 15.6

Description

Related Issue

Solves issue #29.

https://github.com/AnthonMS/my-cards/issues/29

Motivation and Context

Solves issue #29.

How Has This Been Tested

Tested with MacOS Safari Version 15.5 and Safari on iOS 15.6

Types of changes

[x] 🐛 Bug fix (non-breaking change which fixes an issue)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 🌎 Translation (addition or update a translation)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have tested the change locally.

AnthonMS commented 2 years ago

Looks good. I thought it might have been an easy fix like this, but I haven't had time setting up MacOS on a virtual machine yet.

But thank you for your contribution!

AnthonMS commented 2 years ago

Still not working on iPadOS 15 and 16 beta.

AndyVRD commented 2 years ago

Just clearing out, V2 is working fine on iPadOS15 and iPadOS16 beta 2, tested horizontal and vertical. I told Anthon it was not working but it seems to be a cache issue. Finally iOS, iPadOS and Safari users can now use the slider anywhere instead of using the Thumb. Great work guys!

AnthonMS / my-cards