Anthony-E-Cruz / Pinspiration

3 stars 0 forks source link

PA Review: User Auth #2

Open kkossally opened 4 years ago

kkossally commented 4 years ago

User Auth

Functionality

[x] The main button with logo should link to /
[x] Has working demo login
[x] Smooth, bug free navigation

Before Login

[x] The /login page should not display a link to Log In. Same for /signup
[ ] Going to a random route /#/oweiniouewbrviuwebv should redirect or display a 404 page
[x] Errors should display for both /signup and /login.
[x] Errors should clear when moving between /signup and /login.
[x] Can sign up a user
[x] Can sign in as a user
[x] Can log out a user
[x] Can't sign up with the same username/email
[x] Pressing enter after filling out the session form should use the form data, not the demo user

After Login

[x] Should not be able to visit /login or /signup
[x] Should be able to refresh the page and still be logged in

Style

[ ] The site should look exactly like the actual site
[x] All relevant elements should have cursor: pointer on hover
[x] When errors are displayed, most elements should not move around the page (particularly input boxes)

Seeds

[x] Adequate and appropriate seeds

kkossally commented 4 years ago

Really great stuff!

[ ] Re-write your login error so that it doesn't give away whether the password or email is incorrect.
[ ] Use a sans-serif font for the error messages and color the text red.
[ ] Signing up with an email that already exists gives me a password too short error.
[ ] After you finish your Collages/Images MVP, add some content to your splash page. At that point you can make your session forms modals like the original site.