Search E2E tests - Githubissues

zabeen commented 6 months ago

These are the most common search types:
- [x] 10/10 donor search
- [x] 4/8 cord search
- At present will not encode mismatch adult search as this will be covered by 4/8 cord.
- There is no algorithmic difference between treatment of adults and cords.
- Search must have match prediction and scoring enabled.
Exception paths:
- [x] search request with missing required info - should return validation errors in initial request
- [x] search request with invalid HLA - should return a request id, but then fail during matching

want tests to complete as quickly as possible
use patient/donor HLA that is "rare" to reduce number of potential matches at db level
use registry filtering to minimise number of donors being passed onto match prediction

[x] Generate and upload a very small test HF set that has registry code aligned to E2E tests
- e.g., take last 10 haplotypes from WMDA global HF set (i.e., the 10 with lowest frequency)
[x] Generate a test HLA phenotype from the test HF set
- this phenotype should thus be "represented" and generate match prediction values
- extend the phenotype with DPB1 typing so DPB1 scoring will result in a value
[x] Use test phenotype to manually generate matching result and search result json files for use in ApprovalTests-based assertions
- Note: as parts of the resultset will vary between runs, only store the single result for the test phenotype
- Removed:
  - donor code
  - atlas id
  - HF set id

zabeen commented 6 months ago

Testing notes:

I ran the test phenotypes in UAT-WMDA-ATLAS, and it came back with 0 donors in a 10/10 search and 61 cords in a 4/8 search.
This proves that the phenotype is rare and even without registry filtering returns very few matches.

zabeen commented 6 months ago

Anthony-Nolan / Atlas.Auto.Tests