Anthony-Nolan / Atlas

A free & open-source Donor Search Algorithm Service
GNU General Public License v3.0
9 stars 5 forks source link

Orientate positional scores to donor typing #1012

Closed zabeen closed 1 year ago

zabeen commented 1 year ago

Positional scores are currently orientated to patient typing, but it makes more sense for them to be aligned to donor typing - and that is the expectation from WMDA (current AN search implementation does not care about the orientation; it does not show this data to users, only the overall grade/match count).

zabeen commented 1 year ago

AN Testing Notes

This change can only be regression tested on AN - it needs more thorough testing on WMDA, where the issue was first reported.

Regression test:

DmitriyShcherbina commented 1 year ago

@zabeen It looks ok from my perspective "searchIdentifier": "163fd602-eeba-4413-a32e-b3f03e2baae0"

image
zabeen commented 1 year ago

WMDA Testing

Once the change has been deployed to WMDA Dev, need to re-run search 8956421b-8305-463b-ac26-eea97db1350a, and check orientation of DRB1 scores on donors 267964142 and 267967416. Position 2 should be called mismatch.

Passed - both scoring and match prediction grades had the mismatch in the DRB1_2 position

If that looks good, then release to Prod and re-run searches raised by super-users (will need search IDs for this).

Passed - re-ran case 8 from super-user testing, and DRB1 mismatch is in the expected position.