SubmitDataRefreshRequest should not throw exception when scheduled and no data refresh required

[zabeen]

• SubmitDataRefreshRequest is a timer function on Atlas.MatchingAlgorithm.Functions that submits a non-forced data refresh request according to schedule
• If HMD does not need to be recreated (and because the request is non-forced), currently an exception is thrown
• The exception is registered within AI as a failed request which we are monitoring in Live, so it means support is wasting a few mins looking into the Failures when it is not needed.
• As this is an acceptable scenario - i.e., we expect most scheduled requests to not lead to data refresh - an exception should not be thrown in the automated case.

Solution:

• if wasManuallyRequested is false, then log the error message as a Warning Trace instead and early return new DataRefreshResponse {WasRefreshRun = false};
• else (if a manual request) then throw the exception, as currently happens.

[zabeen]

Testing Notes

On AN Dev, HMD is already on latest version and so any non-forced requests should not lead to data refresh running.

Feature testing of the Scheduled job:

• Update matching algorithm app settings:
  • DataRefresh:AutoRunDataRefresh to true
  • DataRefresh:CronTab to suitable value to prompt the function SubmitDataRefreshRequest to run during the test period
• After the schedule run, check results:
  • it should have completed successfully
  • AI logs should show a trace warning message: "Active HLA metadata dictionary is already on the latest version of the WMDA HLA nomenclature and refresh was not run in 'Forced' mode."
• Clean up: reset the app settings to original values

Regression Test of Manually triggered job

• Send http request to SubmitDataRefreshRequestManual with request body {"forceDataRefresh": false}
• Results:
  • Request should return 500 error
  • Exception should be logged to AI: "Active HLA metadata dictionary is already on the latest version of the WMDA HLA nomenclature and refresh was not run in 'Forced' mode."

[DmitriyShcherbina]

@zabeen Feature testing status: Ok

Regression testing: SubmitDataRefreshRequestManual with forceDataRefresh: false returned 400 error but not 500

[zabeen]

@DmitriyShcherbina

Regression testing: SubmitDataRefreshRequestManual with forceDataRefresh: false returned 400 error but not 500

Ah, that seems ok, as it's BadRequest error. As long as it returns a sensible error code, I consider it a pass.