Configure Atlas to be able to reject Full mode donor import files

Anthony-Nolan / Atlas

A free & open-source Donor Search Algorithm Service

GNU General Public License v3.0

9 stars 5 forks source link

Configure Atlas to be able to reject Full mode donor import files #1155

Closed zabeen closed 6 months ago

zabeen commented 8 months ago

Work prompted by live support issue for WMDA-ATLAS.

Donors were missing from search because donor import files had been uploaded in Full mode instead of Diff mode, which meant no internal updates had been published for these donors, and they were not visible to matching algorithm.

Further, the error was not caught by the donor-id-checker feature as it only checks the donor store db, not the active matching algorithm db.

One mitigation for this exception path is to allow Atlas to reject Full mode files, as they are only intended for use when setting up a new install of Atlas.

HLD

add a new bool app setting to Donor Import functions app: allowFullModeImport
it should default to false
Add check to DonorFileImporter - if file is in full mode and allowFullModeImport is false, then mark the entire import as failed, and raise an alert.
terraform new setting, and allow it to be set by release var

zabeen commented 7 months ago

Testing Notes

Check donor import functions config: DonorImport:AllowFullModeImport should be false
Upload a valid donor import file in Full mode:
- import result message should says wasSuccess is false
- alert message says file was not imported as full mode import not allowed
Upload a valid donor file in Diff mode:
- import result message should says wasSuccess is true
- no alert message
Manually set DonorImport:AllowFullModeImport to true
Upload a valid donor import file in Full mode:
- import result message should says wasSuccess is true
- no alert message
Again, upload a valid donor file in Diff mode:
- import result message should says wasSuccess is true
- no alert message
Clean-up - make sure to reset DonorImport:AllowFullModeImport to false

E2E tests

Extend the donor import E2E test case for full mode import to account for this new setting.

DmitriyShcherbina commented 7 months ago

@zabeen Testing status: Ok DonorImport:AllowFullModeImport=false

DonorImport:AllowFullModeImport=true

DmitriyShcherbina commented 7 months ago

@zabeen Regarding extendng E2E test-cases with this scenarios, maybe it makes sense to create separate ticket for it, in order not to delay this tested ticked in AN Dev Testing status?

zabeen commented 7 months ago

@DmitriyShcherbina makes sense, I just added a comment to end of the existing E2E tests ticket we've had open for a while