Anthony-Nolan / Atlas

A free & open-source Donor Search Algorithm Service
GNU General Public License v3.0
9 stars 5 forks source link

Add debug endpoint to query application insights for HLA expansion failure #1231

Closed zabeen closed 5 months ago

zabeen commented 6 months ago

https://learn.microsoft.com/en-us/azure/azure-monitor/logs/api/overview

HLD

SergeyEzh commented 6 months ago

@zabeen, PR is created for this item (https://github.com/Anthony-Nolan/Atlas/pull/1248). Here is just couple notes:

I have added new release variable AZURE_TENANT_ID. Therefore, it should be set in release pipelines on both AN and WMDA instances of Azure Devops. However, I noticed that existing release variable (DATABASE_SERVER_AZUREAD_ADMINISTRATOR_TENANTID) has the same value as currently we need. So we can avoid updating azure devops by reusing this variable. But I'm not sure if it always be the same.

Also, do I need add this new release variable to README_Configuration.md?

Currently, result looks like that:

Image

Do I need unwrap ExternalDonorCodes? I didn't do it initially, because ExceptionType and ExternalDonorCodes have the same type in results, so I can't distinguish them without examining property names. But it would reduce flexibility if query will be changed. What is the priority?

zabeen commented 6 months ago

Also, do I need add this new release variable to README_Configuration.md?

yes please

Do I need unwrap ExternalDonorCodes? I didn't do it initially, because ExceptionType and ExternalDonorCodes have the same type in results, so I can't distinguish them without examining property names.

Please unwrap, and map to a new model in Debug.Client.Models project, this will be the return type in the Debug.Client method.

But it would reduce flexibility if query will be changed. What is the priority?

This query shouldn't change anytime soon. It's been in use for a while and is working well (at least, pre-workspace migration!)