Anthony-Nolan / Atlas

A free & open-source Donor Search Algorithm Service
GNU General Public License v3.0
9 stars 5 forks source link

Do not replay search request when HLA validation failed #708

Closed benbelow closed 2 years ago

benbelow commented 2 years ago

since #707 we should be able to identify HLA lookup errors.

Currently these retry up to the retry limit (10 by default), causing a failure notification each time, and eventually ending up on the dead letter queue.

Suggestion: Instead, consider such messages "successfully processed". This would mean we only get one failure notification, and the messages will not end up on the dead letter queue, meaning we can reliably say that anything on the DL queue is a problem.

benbelow commented 2 years ago

Confirmed with @mmelchers and @WMDAJesse that this would be useful to WMDA

benbelow commented 2 years ago

TESTING