Anthony-Nolan / Atlas

A free & open-source Donor Search Algorithm Service
GNU General Public License v3.0
9 stars 5 forks source link

Repeat search - changes in match prediction results not caused by a donor update #752

Closed benbelow closed 1 year ago

benbelow commented 2 years ago

Currently repeat search only reports on differences in the full set of matching donors - i.e. whether there are any new donors added to the results, or any previous results are no longer a match.

It will not re-run match prediction for donors that were and still are a match. This means that match prediction results should be considered a snapshot of the donor at the time the original search was run, and not always trusted in perpetuity.

Ways this could change without a donor HLA update:

zabeen commented 1 year ago

Not sure the above ticket description in 100% accurate, we do report previously matched donors that have been updated since the cut-off date, and match prediction is calculated for both them and the new donors (link to code).

However, it is true that uploading a new HF set, or modifying the mapping of HF sets will not cause the affected donors to be eligible for repeat search.

zabeen commented 1 year ago

I am closing this ticket as there is no requirement to make donors eligible for repeat search when a new HF set has been uploaded. Can re-create the ticket with exact requirements if it ever comes up.