Move repeat search props & service logic to new classes

Anthony-Nolan / Atlas

A free & open-source Donor Search Algorithm Service

GNU General Public License v3.0

9 stars 5 forks source link

Move repeat search props & service logic to new classes #753

Closed benbelow closed 1 year ago

benbelow commented 2 years ago

Repeat search specific properties and logic were added to existing search request models and services; request for them to be added to new repeat search models/services that inherit from search request base classes.

e.g., https://github.com/Anthony-Nolan/Atlas/blob/bb168130c1bb814f95bac8a7a267d7dc83863088/Atlas.Client.Models/Search/Requests/SearchInitiationResponse.cs#L14

zabeen commented 1 year ago

Closing this, as even though it would be cleaner, it doesn't seem worth it anymore now client models have been published and Atlas deployed to several places!