search

Anthony-Nolan / Atlas

A free & open-source Donor Search Algorithm Service
GNU General Public License v3.0
9 stars 5 forks source link

Internal InitiateRepeatSearch function returning incorrect IDs #755

Open benbelow opened 2 years ago

benbelow commented 2 years ago

This bug only applies to the internal function: Atlas.RepeatSearch.Functions.Functions > InitiateRepeatSearch, not the public API level function of the same name.

In http result body, the searchIdentifier prop is being populated with the new repeat search Id, whilst the repeatSearchIdentifier is being set to null.

mmelchers commented 1 year ago

I do not know whether this bug is still applicable. I know that repeat search does not seem to work at the moment, but that is handled in ticket https://github.com/Anthony-Nolan/Atlas/issues/892

@seanmobrien @zabeen is this ticket still applicable?

zabeen commented 11 months ago

@mmelchers sorry for late response, #892 has been resolved as being due to malformed request. I assume this issue is still open as no work has been done to fix it! But it should not affect S&M as you initiate repeat search via the Public API endpoint. The endpoint mentioned above is on a different function app.

I may actually just remove that function entirely, or at very least, move it to the debug namespace to make it clear it is non-prod.