Anthony-Nolan / Atlas

A free & open-source Donor Search Algorithm Service
GNU General Public License v3.0
9 stars 5 forks source link

Test Pipeline should be runnable outside of AN environment #875

Closed seanmobrien closed 1 year ago

seanmobrien commented 1 year ago

Describe the bug Test Pipeline uses unique resource names that are already deployed in AN's environment. This results in test pipeline failures during the Terraform and Matching Algorithm Validation stages.

To Reproduce Steps to reproduce the behavior:

  1. Use test-pipeline.yml to create a new Pipeline in Azure DevOps
  2. Create a Variable Group named 'Terraform', and update with Client Id / Secret / Access keys necessary for Terraform to connect to Azure.
  3. Run pipeline
  4. Pipeline fails at the Terraform (unique resource names) and Matching Algorithm Valdation (no access to AN nuget feed).

Expected behaviour Test pipeline should successfully deploy resource to the test resource group and be able to fetch all packages needed for tests to run successfully.

Screenshots N/A

Inputs/Outputs Set the following values in the Terraform variable group:

ARM_ACCESS_KEY: [access key to storage account] ARM_CLIENT_ID: [client id used by terraform to connect to resources] ARM_CLIENT_SECRET: [client secret used by terraform to connect resources] ARM_TENANT_ID: [azure tenant id test resources are deployed to[ BACKEND_RESOURCE_GROUP_NAME: [Name of the back-end resource group] BACKEND_STORAGE_ACCOUNT_NAME: [Name of the storage account used by terraform] BACKEND_STORAGE_CONTAINER_NAME: [Name of the storage container used by terraform]

Atlas Build & Runtime Info (please complete the following information):

Additional context This issue was discovered while running test pipelines in WMDA's DevOps instance

zabeen commented 1 year ago

@seanmobrien to look at why AN's system test build pipeline is broken.

seanmobrien commented 1 year ago

Fixed with https://github.com/Anthony-Nolan/Atlas/pull/888