Update to a missing donor prevents processing of other records in import file

[seanmobrien]

Describe the bug When a donor file that includes an update to a non-existing donor is processed, the donor file import logs a single failure and does not process any other donors in the file. It should fail to import the non-existing donor, but process other donor updates in the file.

To Reproduce Steps to reproduce the behavior:

1. Upload a donor file that contains an U (update) record for a non-existant donor and at least one other valid record

2. Run this query in AI, observe the donor import file was processed and logged 'Could not find expected donor in Atlas database' error traces | union exceptions | order by timestamp desc | where operation_Name == "ImportDonorFile"

3. Run the following SQL query against ATLAS database. Observe record for uploaded file is in FileState FailedPermanent with a single failure logged. No donors were imported. SELECT TOP (1000)* FROM [Donors].[DonorImportHistory] order by ImportBegin desc

Expected behaviour Donor import should process all valid records in the file and continue to log / count failed donor updates.

Screenshots

Inputs/Outputs 2023-03-13-16-00-01-465-alldif-donors-8139.json on WMDA's dev environment can replicate this issue.

Atlas Build & Runtime Info (please complete the following information):

• Runtime Environment: Azure / WMDA Dev
• Atlas Version: wmda/master branch f0a223a45b49f248023ea09feb63a0456a753b05 (based off AN master commit cc78cc30 )
• GitHub commit ID of Atlas build cc78cc30

[zabeen]

Notes about different update combinations and which ones should give errors: https://github.com/Anthony-Nolan/Atlas/blob/master/README_DonorImport.md#donor-import-file-behaviour-if-out-of-order

[daria-sorokina-da]

For QA:

• Check existing tests for donor import
• Modify them to make sure that the failures of individual donors do not lead to a failure of the whole batch
• Migrate them to Git

Scenarios:

• Success: Create, Update, Delete; Upsert, Upsert, Delete
• Error in logs: Create, Create; Delete, Delete - should not affect other donors in the same file

[DmitriyShcherbina]

@daria-sorokina-da testing is OK Passed test:

• "N" (Create) donors import
• "D" (Delete) donors import
• "N" (Create) donor import of already imported donor
• "D" (Delete) donor import of already deleted donor

[mmelchers]

Seems to work as expected.