Closed seanmobrien closed 1 year ago
Notes about different update combinations and which ones should give errors: https://github.com/Anthony-Nolan/Atlas/blob/master/README_DonorImport.md#donor-import-file-behaviour-if-out-of-order
For QA:
Scenarios:
@daria-sorokina-da testing is OK Passed test:
Seems to work as expected.
Describe the bug When a donor file that includes an update to a non-existing donor is processed, the donor file import logs a single failure and does not process any other donors in the file. It should fail to import the non-existing donor, but process other donor updates in the file.
To Reproduce Steps to reproduce the behavior:
Upload a donor file that contains an U (update) record for a non-existant donor and at least one other valid record
Run this query in AI, observe the donor import file was processed and logged 'Could not find expected donor in Atlas database' error![Snag_4d2a9ca](https://user-images.githubusercontent.com/8743939/224785341-1cb6e6cc-6e44-4bae-aa61-11a4740a9184.png)
traces | union exceptions | order by timestamp desc | where operation_Name == "ImportDonorFile"
Run the following SQL query against ATLAS database. Observe record for uploaded file is in FileState FailedPermanent with a single failure logged. No donors were imported.![Snag_4d4da37](https://user-images.githubusercontent.com/8743939/224785939-ad1e2383-9724-4ac0-aad1-ca3f51e1a218.png)
SELECT TOP (1000)* FROM [Donors].[DonorImportHistory] order by ImportBegin desc
Expected behaviour Donor import should process all valid records in the file and continue to log / count failed donor updates.
Screenshots
Inputs/Outputs 2023-03-13-16-00-01-465-alldif-donors-8139.json on WMDA's dev environment can replicate this issue.
Atlas Build & Runtime Info (please complete the following information):