Failed searches resulting in dead-letter message on repeat search sub of matching results topic

[seanmobrien]

Describe the bug Failed searches result in a dead-letter message being added to the matching-results-ready/repeat-search subscription

To Reproduce Steps to reproduce the behavior:

Run a search that encounters an error. Using service bus explorer, look at the matching-results-ready/repeat-search dead letter queue. Observe new message in dead-letter queue. Note the BlobStorageContainerName and ResultsFileName are null and failure info is non-null. ArgumentNullExceptions are logged in AI.

Expected behaviour matching-results-ready/repeat-search messages are successfully delivered, regardless of whether the search was successful

Inputs/Outputs Sample dead-lettered message: {"SearchRequest":null,"IsRepeatSearch":false,"MatchingAlgorithmServiceVersion":"1.0.0.0","ElapsedTime":"00:00:00","ValidationError":null,"FailureInfo":{"ValidationError":null,"AttemptNumber":1,"RemainingRetriesCount":9},"SearchRequestId":"b3a533c6-6ee5-4c46-b085-db8a7637991b","WasSuccessful":false,"RepeatSearchRequestId":null,"BlobStorageContainerName":null,"ResultsFileName":null,"NumberOfResults":null,"MatchingAlgorithmHlaNomenclatureVersion":"3510"}

Atlas Build & Runtime Info (please complete the following information):

Runtime Environment: Azure Cloud (WMDA) Atlas Version: N/A GitHub commit ID of Atlas build: https://github.com/Anthony-Nolan/Atlas/commit/8b9ac325d2e0bbfdbc82763268df2b10131994cf

[daria-sorokina-da]

Steps:

• search fails in Atlas
• a failed search message is added to repeat-search queue
• repeat search processor picks up this message and tries to load the results, which are not there, so it fails

Expected result: The repeat search processor should ignore the messages with failure results, and not deadletter

[DmitriyShcherbina]

AN test status: OK

[zabeen]

I don't think this actually needs re-testing in WMDA environment as testing in AN Dev should be sufficient, so moving to Final Review column.