Anthony-Nolan / Atlas

A free & open-source Donor Search Algorithm Service
GNU General Public License v3.0
9 stars 5 forks source link

DPB1 typing with Null allele should be treated as homozygous during TCE group scoring #925

Closed zabeen closed 1 year ago

zabeen commented 1 year ago

Describe the bug Patient typing at DPB1 had a null allele (DPB1 *02:01, *64:01N) and the donors in their search results were not scored for DPB1 match grade, instead they all had the assignment of U.

To Reproduce Steps to reproduce the behavior:

  1. Run a search request with DPB1 scoring enabled, with DPB1 excluded from aggregate scoring. DPB1 typing should contain one null-expressing allele (e.g., DPB1 *02:01, *64:01N) - the exact patient search HLA that triggered this ticket is available on request.
  2. On completion of search, download the results file from blob storage.
  3. Scroll down to a scoring result for a donor typed with DPB1, and you will see following:
    "Dpb1": {
                        "IsLocusMatchCountIncludedInTotal": false,
                        "MatchCategory": "Unknown",
                        "MatchCount": 0,
                        "IsLocusTyped": true,
                        "MismatchDirection": "NotApplicable"
                    }
  4. AI Logs for search will also show the following message for each donor that had DPB1 typing: "Could not find patient TCE group pair: (3, ) in hardcoded DPB1 TCE group matching behaviour. Something has likely gone wrong, and the Unknown grade will be used until this is fixed."

Expected behaviour Expect for null-containing DPB1 typings to be treated as if the patient (or donor, where applicable) is homozygous for the expressing allele, and the TCE groups to be calculated accordingly.

Inputs/Outputs Patient HLA and original search results available on request.

Atlas Build & Runtime Info (please complete the following information):

Additional context Link to DPB1 TCE group calculator that needs to be extended with null-handling logic

zabeen commented 1 year ago

Testing Notes

DmitriyShcherbina commented 1 year ago

@zabeen dev testing status: ok In my test result Dpb1.MatchCategoty has Mismatch value

Image

zabeen commented 1 year ago

@DmitriyShcherbina fantastic, LGTM!