search

Anthony-Nolan / Atlas

A free & open-source Donor Search Algorithm Service
GNU General Public License v3.0
9 stars 5 forks source link

Search results file is absent in atlas-search-results blob container in case of Search request with "runMatchPrediction": false #935

Open DmitriyShcherbina opened 1 year ago

DmitriyShcherbina commented 1 year ago

Steps to reproduce:

  1. Run Search request with "runMatchPrediction": false
  2. Note searchIdentifier in Search request response
  3. Go to atlas-search-results blob container
  4. Look for Search results file with Identifier noted in step 2

Actual Result: Search results file is absent in atlas-search-results blob container in case of Search reqiest with "runMatchPrediction": false But search results file presents in matching-algorithm-results blob container

Expected Result: Search results file presents in atlas-search-results blob container in case of Search reqiest with "runMatchPrediction": false

IgorKupreychik commented 1 year ago

In the code I see we doesn't even start the second part when "runMatchPrediction" is false: https://github.com/Anthony-Nolan/Atlas/blob/master/Atlas.Functions/DurableFunctions/Search/Client/SearchClientFunctions.cs#L40

daria-sorokina-da commented 1 year ago

Checked AN Atlas search requests - all of them have "runMatchPrediction": false, so we definitely need a fix for this issue

daria-sorokina-da commented 1 year ago

This is a known issue - AN Atlas Search checks matching-algorithm-results blob container, so this is OK for now.

zabeen commented 1 year ago

This is not a bug per se, but an intentional design choice, though admittedly not so intuitive, and so could be revisited in future.