search

Anthony-Nolan / Atlas

A free & open-source Donor Search Algorithm Service
GNU General Public License v3.0
9 stars 5 forks source link

Inconsistent antigen match values during WMDA exercise set 2 #978

Closed zabeen closed 1 year ago

zabeen commented 1 year ago

Analysis of exercise 2 results from #964 shows some inexplicable ag mismatch discrepancies. On submitting the listed patient donor pair to AN DEV ScoreBatch function, the incorrect result is returned, in keeping with the exercise results. But then submitting the same ScoreBatch request after restarting the matching algorithm functions will get the correct answer.

Restarting the functions app clears the scoring cache, forcing the score to be generated from scratch. This suggests that at some point during the exercise, the incorrect answer is being cached, and then returned every time the same HLA pair is submitted.

zabeen commented 1 year ago

I suspect the use of the match grade is contributing to this problem, so I have removed it from the ag match calculator - it now only looks for overlapping assigned serologies. If the patient or donor typing has no assigned serologies, then the result will be null.

zabeen commented 1 year ago

Re-ran exercise 2 and results are now consistent.