C++17: Class template argument deduction

[kevin-strobel]

The user-defined deduction guide is incorrect and does not compile.

Instead of the repeated template keyword, the example requires typename or class inside the angle brackets.

See also cppreference.

[AnthonyCalandra]

Looks like a typo on my end, thanks for taking a look.

Also it looks like your changes in the README added a bunch of new lines, can you remove those? Otherwise looks good.

[kevin-strobel]

Also it looks like your changes in the README added a bunch of new lines, can you remove those? Otherwise looks good.

The new lines will be inserted automatically when running auto-generate-readme.py.

My intention was to commit them in order to synchronize committed and generated state again.

However, if you like, I'll remove them.

[AnthonyCalandra]

Yes please remove them.

I'm removing the generate script because I had some problems with it before and I don't think it's worth the effort to try and fix it; haven't gotten around to doing that yet.

[kevin-strobel]

From what I've found out:

The script will be run when someone commits and pushes into an existing pull request, leading to a new "new line removal" commit. It seems not to run when creating a new pull request.

So

• either I comment out the workflow in main.yml
• or I close this pull request and create a new one with only my changes since this seems to skip the workflow for now

[AnthonyCalandra]

Despite disabling it I do see the commit from the Github Actions Bot.

Really strange... I don't know exactly how Github Actions work at all so I'll remove all the scripts. Give me a few minutes.

[AnthonyCalandra]

Ok, everything is remove I think. Sorry for all the extra overhead. Should be good to pull in the latest changes now.

[AnthonyCalandra]

LGTM

[kevin-strobel]

Thank you for helping me get rid of the bot commit :relieved:.