AnthonyDeroche / mod_authnz_jwt

An authentication module for Apache httpd using JSON Web Tokens
Other
79 stars 46 forks source link

Features/integrate cookie branch #42

Closed weh closed 3 years ago

weh commented 4 years ago

I needed the ability to send JWT using a Cookie. So i tried to integrate the already present branch from ghetolay. Credit for the Implementation belongs to @ghetolay. I don't know the exact status of his branch. So i tried to merge and use it in its current state.

This is what i did:

Disclaimer: I am not a C programmer, so i would be happy if someone with C knowledge could review this changes. This would close #28

tha80 commented 4 years ago

I also need the possibility to have the JWT token in a cookie. I have tested the code from this PR and it works very well for me. But to be honest, I also made no real code review. Nevertheless I would be very happy if this PR could be merged into master in near future. I think a lot of people would benefit from it.

ghetolay commented 4 years ago

Hi, I need to find some time to finish this indeed. I got it working on a POC and got no problem so far but usage is very simple and limited. If I remember correctly what's left to do are mostly tests and user configuration.

AnthonyDeroche commented 3 years ago

Hi, could you rebase your branch on master when you are done with this work so I can review and merge ? Thanks for the contribution.

weh commented 3 years ago

@AnthonyDeroche Rebase is done, i think it is ready to review.

harrylepotter commented 3 years ago

@weh @ghetolay this is an amazing patch.

Voldemar123 commented 3 years ago

Hello all! lets merge and release new module version ? I am waiting for this feature

AnthonyDeroche commented 3 years ago

I need to review & test before merging. I was in holidays, I should be doing this in the next few days.