add new OCs - Githubissues

kagrith commented 5 months ago

Hiya, just wanted to chime in here. I downloaded this and shoved it into the build. I got the following error (sanitized)

json.decoder.JSONDecodeError: Expecting ',' delimiter: line 2074 column 5 (char 53715)

Sure enough, end of line on 2073 is missing a comma delimiter, just like line 2059 for reference.

Which led to error: json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 2243 column 1 (char 58143)

This was less clear to me. 2243 appears to be the end of the file, after pruning some whitespace, It occured to me that there appeared to be an unnecessary comma on line 2241. Being that JSON is a comma delimited format, the last item in a list should not have a trailing comma.

Sure enough, after making those changes, running main.py opened the editor right up. I brought a save file in, and set the overclocks to unacquired, and sure enough, they populated properly.

I noticed that the M1000 Classic, DeepCore GK2, and Thunderhead appeared to not show my existing overclocks as forged. I added them to be cautious.

The seasonal section appears to need some work still. I've backed up my saves just in case, but ill be saving and testing the file anyway, just to see if keeping the values the same does allow for easy acquisition of the new overclocks.

Edited to add my revisions to the GUIDs json.

Edit 2: When saving the file i noticed the following output in powershell.

  File "~\DRG-Save-Editor-master\src\main\python\main.py", line 1273, in <module>
    exit_code = appctext.app.exec_()
  File "~\DRG-Save-Editor-master\src\main\python\main.py", line 591, in save_changes
    save_file: bytes = make_save_file(file_name, changes)
  File "~\DRG-Save-Editor-master\src\main\python\main.py", line 795, in make_save_file
    uuids: list[bytes] = [bytes.fromhex(i) for i in unforged_ocs.keys()]
  File "~\DRG-Save-Editor-master\src\main\python\main.py", line 795, in <listcomp>
    uuids: list[bytes] = [bytes.fromhex(i) for i in unforged_ocs.keys()]
ValueError: non-hexadecimal number found in fromhex() arg at position 32

Not sure how to handle that one. Going to try loading the file anyway.

Edit 3: Appears something in the saving process needs to be rectified. Perhaps a problem with some of the overclocks. Removing them and only adding one gives error

Traceback (most recent call last):
  File "C:\Users\Engineer\Downloads\DRG-Save-Editor-master\src\main\python\main.py", line 1273, in <module>
    exit_code = appctext.app.exec_()
  File "C:\Users\Engineer\Downloads\DRG-Save-Editor-master\src\main\python\main.py", line 575, in add_cores
    del unacquired_ocs[i.text(2)]
KeyError: '94DEB4484193354DBBFC0E92C535D2AD

LordFoogThe4rd commented 5 months ago

I noticed that the M1000 Classic, DeepCore GK2, and Thunderhead appeared to not show my existing overclocks as forged. I added them to be cautious.

but all other overclocks show properly? I saw that the GUIDs in the game file was different so I thought I had to update that too, seems like I need to rollback

kagrith commented 5 months ago

but all other overclocks show properly? I saw that the GUIDs in the game file was different so I thought I had to update that too, seems like I need to rollback

Seems to do, yes. Just the ones referenced appeared to be mismatched for some reason. T'was the whole category by the look of it.

AnthonyMichaelTDM commented 5 months ago

Hey, thanks for doing this. When this PR is ready, and someone else can confirm it’s working, ping me specifically and I’ll get it merged.

LordFoogThe4rd commented 5 months ago

@kagrith can you test this change?

LordFoogThe4rd commented 5 months ago

all new OCs show up as unacquired but I have forged them... not sure what went wrong

LordFoogThe4rd commented 5 months ago

@AnthonyMichaelTDM where did you get the GUIDs? there are 2 files that contain different GUIDs, the OC file itself and OSB_WeaponName

AnthonyMichaelTDM commented 5 months ago

I got them from save files

LordFoogThe4rd commented 5 months ago

I got them from save files

how? did you use a hex editor?

AnthonyMichaelTDM commented 5 months ago

Yes, exactly, I forgot the exact one I used i think it was like “hex3d” or something idk, it was a windows app so I can’t use it anymore bc I use Linux now

LordFoogThe4rd commented 5 months ago

Yes, exactly, I forgot the exact one I used i think it was like “hex3d” or something idk, it was a windows app so I can’t use it anymore bc I use Linux now

how did you identify the OCs? test one by one?

AnthonyMichaelTDM commented 5 months ago

Pretty much, it’s kind of a pain in the ass

kagrith commented 5 months ago

@kagrith can you test this change?

Tried the new guids file. No errors when saving, however, when loading up the game, none of the new overclocks showed up. Adjusted a level to check if the safe file was being read by the game properly, and sure enough, new levels showed up, but the OCs remain outside of forge.

BlitWizbok commented 5 months ago

Can confirm @kagrith findings. OC's are in the editor, and there's no errors when saving, but they're absent from the forge.

LordFoogThe4rd commented 5 months ago

Pretty much, it’s kind of a pain in the ass

does the forgedschematics section contain cosmetic schematics? or only overclocks

AnthonyMichaelTDM commented 5 months ago

I think it's just overclocks, but don't cite me on that.

On Fri, Jun 21, 2024 at 5:28 AM LordFoogThe4rd @.***> wrote:

Pretty much, it’s kind of a pain in the ass

does the forgedschematics section contain cosmetic schematics? or only overclocks

— Reply to this email directly, view it on GitHub https://github.com/AnthonyMichaelTDM/DRG-Save-Editor/pull/60#issuecomment-2182658413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQKQEKCTKE6VTZ4XHY376ZDZIQL6RAVCNFSM6AAAAABJDNGX4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSGY2TQNBRGM . You are receiving this because you were mentioned.Message ID: @.***>

LordFoogThe4rd commented 5 months ago

if anyone wants to help me, you can make a new savegame with ONLY weapon overclocks and send the save here so I can look into it, also do forge them

Ecksters commented 4 months ago

@LordFoogThe4rd https://github.com/AnthonyMichaelTDM/DRG-Save-Editor/issues/61#issuecomment-2185256782

wahlp commented 4 months ago

looking through the changes, i think the GUIDs updated might be wrong.

based on my own testing, the reworked stubby overclock's GUID has stayed the same since the update and does not actually need changing.

all the other changed GUIDs might also be incorrect. this would explain how there are no errors when saving, but the overclocks don't appear.

@LordFoogThe4rd i'm willing to hunt down the correct GUIDs if you need help

xXramzS commented 4 months ago

Please do let me know if there is anything i can do. if it's a matter of trial and error i mean, and you need help dividing the task, i could wholeheartedly help.

wahlp commented 4 months ago

using that save with all the OCs, i made a save with the 12 new OCs waiting to be forged. there may be a 1 or 2 additional GUIDs under OwnedSchematics that don't appear ingame, which i think means they're not valid. season5-ocs-unforged.zip

by forging them one by one, i've identified which GUID belongs to which OC. this is what it looks like now. guids.json

anyone can try replacing the current guids.json with that and see if it works.

kagrith commented 4 months ago

I'll give this a try shortly. Will advise.

On Sat, Jul 6, 2024, 17:02 wahlp @.***> wrote:

using that save with all the OCs, i made a save with the 12 new OCs waiting to be forged. there may be a 1 or 2 additional GUIDs under OwnedSchematics that don't appear ingame, which i think means they're not valid. season5-ocs-unforged.zip https://github.com/user-attachments/files/16117420/season5-ocs-unforged.zip

by forging them one by one, i've identified which GUID belongs to which OC. this is what it looks like now. guids.json https://github.com/user-attachments/files/16117390/guids.json

anyone can try replacing the current guids.json with that and see if it works.

— Reply to this email directly, view it on GitHub https://github.com/AnthonyMichaelTDM/DRG-Save-Editor/pull/60#issuecomment-2211984671, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACIBQWDWMPFF6PCHP5XZ5DDZLBSOBAVCNFSM6AAAAABJDNGX4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRHE4DINRXGE . You are receiving this because you were mentioned.Message ID: @.***>

xXramzS commented 4 months ago

Haven't tried all OCs, but Mortar Rounds, Pump Action and Rotary Overdrive work.

xXramzS commented 4 months ago

okay i've tried almost all of them, it seems to work. i think let someone else try too, but it seems fine

kagrith commented 4 months ago

Can confirm all 12 overclocks were forge-able after plugging in this guids.

using that save with all the OCs, i made a save with the 12 new OCs waiting to be forged. there may be a 1 or 2 additional GUIDs under OwnedSchematics that don't appear ingame, which i think means they're not valid. season5-ocs-unforged.zip

by forging them one by one, i've identified which GUID belongs to which OC. this is what it looks like now. guids.json

anyone can try replacing the current guids.json with that and see if it works.

LordFoogThe4rd commented 4 months ago

using that save with all the OCs, i made a save with the 12 new OCs waiting to be forged. there may be a 1 or 2 additional GUIDs under OwnedSchematics that don't appear ingame, which i think means they're not valid. season5-ocs-unforged.zip

by forging them one by one, i've identified which GUID belongs to which OC. this is what it looks like now. guids.json

anyone can try replacing the current guids.json with that and see if it works.

merged this, thank you

AnthonyMichaelTDM / DRG-Save-Editor

add new OCs #60