search

AnthonyMichaelTDM / DRG-Save-Editor

Rock and stone!
GNU General Public License v3.0
115 stars 17 forks source link

[Proposal] - Migrate from PySide2 to PySide6 (Qt5 -> Qt6) #72

Closed AnthonyMichaelTDM closed 4 months ago

AnthonyMichaelTDM commented 4 months ago

Migrating from pyside2 to pyside6 shouldn't be too difficult and should allow this project to run on the latest version(s) of python.

Going to wait for #68 #64 and #71 before I start this, just to prevent conflicts and whatnot.

AnthonyMichaelTDM commented 4 months ago

this will be in release v1.9.1

AnthonyMichaelTDM commented 4 months ago

@simon-wg , @wahlp , what are your thoughts on moving forward with this? It'd make using this tool on linux easier (by supporting python 3.12, meaning most linux users can just use their systems' python distribution without having to download an older version (e.g. 3.10)), but I don't know how that would effect things on the windows side of things, do you guys have any inputs / insights?

wahlp commented 4 months ago

i think most users are on Windows and will go for the executable once it becomes available, so they wouldn't be concerned with the Python version unless they're also a developer.

developers like me might have to update their environment but i'm ok with that.

AnthonyMichaelTDM commented 4 months ago

i think most users are on Windows and will go for the executable once it becomes available, so they wouldn't be concerned with the Python version unless they're also a developer.

developers like me might have to update their environment but i'm ok with that.

that makes sense

AnthonyMichaelTDM commented 4 months ago

pr is open if you want to take a look

simon-wg commented 4 months ago

I think it's a good idea to migrate. I don't see that the requirement of a more recent python version would be a major problem for anyone. PR looks good, I've added some comments regarding warnings on linux.